-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Assertions in AOT tests are not failing the tests #53588
Comments
Tagging subscribers to this area: @directhex Issue Details@akoeplinger noticed that some of the AOT tests fail with assert, while we don't detect that it fails. Example builds from PRs #52870 and #53557 both fails like this (logs https://helix.dot.net/api/2019-06-17/jobs/f72ceeb4-313b-4c02-86e8-ccb006b5e71a/workitems/System.Buffers.Tests/console, https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53557-merge-03621a4b99b842f8b2/System.Buffers.Tests/console.63585788.log?sv=2019-07-07&se=2021-06-21T23%3A55%3A04Z&sr=c&sp=rl&sig=NNdaRko4%2BgMhFxf17rDWIzsv%2BLx1r9IkKeUg%2B0oo2ic%3D):
|
ah, I was working on the same thing :-) |
Context: dotnet#53588 This change makes the test in above issue fail: fail: console.error: * Assertion at C:/Users/rodo/git/wa-main/src/mono/mono/mini/mini-exceptions.c:3957, condition `<disabled>' not met fail: info: console.info: Arguments: --run,WasmTestRunner.dll,System.Buffers.Tests.dll,-notrait,category=OuterLoop,-notrait,category=failing info: console.debug: MONO_WASM: Initializing mono runtime info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28 info: console.info: Initializing..... info: Discovering: System.Buffers.Tests.dll (method display = ClassAndMethod, method display options = None) info: Discovered: System.Buffers.Tests.dll (found 42 of 44 test cases) info: Starting: System.Buffers.Tests.dll info: Process v8.cmd exited with -1 fail: Application has finished with exit code -1 but 0 was expected XHarness exit code: 71 (GENERAL_FAILURE)
Fixed by #53734 |
@akoeplinger noticed that some of the AOT tests fail with assert, while we don't detect that it fails.
Example builds from PRs #52870 and #53557 both fails like this (logs https://helix.dot.net/api/2019-06-17/jobs/f72ceeb4-313b-4c02-86e8-ccb006b5e71a/workitems/System.Buffers.Tests/console, https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53557-merge-03621a4b99b842f8b2/System.Buffers.Tests/console.63585788.log?sv=2019-07-07&se=2021-06-21T23%3A55%3A04Z&sr=c&sp=rl&sig=NNdaRko4%2BgMhFxf17rDWIzsv%2BLx1r9IkKeUg%2B0oo2ic%3D):
The text was updated successfully, but these errors were encountered: