Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All methods that accept bufferSize and use FileStream internally should allow for passing zero to disable buffering #53497

Closed
adamsitnik opened this issue May 31, 2021 · 2 comments
Assignees
Labels
area-System.IO good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@adamsitnik
Copy link
Member

adamsitnik commented May 31, 2021

This is something I've missed in #52928

public static partial class File
{
    public static System.IO.FileStream Create(string path, int bufferSize) { throw null; }
    public static System.IO.FileStream Create(string path, int bufferSize, System.IO.FileOptions options) { throw null; }
}
@adamsitnik adamsitnik added area-System.IO good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors labels May 31, 2021
@adamsitnik adamsitnik added this to the 6.0.0 milestone May 31, 2021
@ghost
Copy link

ghost commented May 31, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

This is something I've missed in #52928

public static partial class File
{
    public static System.IO.FileStream Create(string path, int bufferSize) { throw null; }
    public static System.IO.FileStream Create(string path, int bufferSize, System.IO.FileOptions options) { throw null; }
}

public partial class StreamReader : System.IO.TextReader
{
    public StreamReader(System.IO.Stream stream, System.Text.Encoding encoding, bool detectEncodingFromByteOrderMarks, int bufferSize) { }
    public StreamReader(System.IO.Stream stream, System.Text.Encoding? encoding = null, bool detectEncodingFromByteOrderMarks = true, int bufferSize = -1, bool leaveOpen = false) { }
    public StreamReader(string path, System.Text.Encoding encoding, bool detectEncodingFromByteOrderMarks, int bufferSize) { }
}

public partial class StreamWriter : System.IO.TextWriter
{
    public StreamWriter(System.IO.Stream stream, System.Text.Encoding encoding, int bufferSize) { }
    public StreamWriter(System.IO.Stream stream, System.Text.Encoding? encoding = null, int bufferSize = -1, bool leaveOpen = false) { }
    public StreamWriter(string path, bool append, System.Text.Encoding encoding, int bufferSize) { }
}
Author: adamsitnik
Assignees: -
Labels:

area-System.IO, easy, up-for-grabs

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 31, 2021
@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label May 31, 2021
@adamsitnik
Copy link
Member Author

It got fixed by #53669

@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

2 participants