Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename libSystem.Security.Cryptography.Native.OpenSsl on Android #52327

Closed
steveisok opened this issue May 5, 2021 · 1 comment · Fixed by #52406
Closed

Rename libSystem.Security.Cryptography.Native.OpenSsl on Android #52327

steveisok opened this issue May 5, 2021 · 1 comment · Fixed by #52406

Comments

@steveisok
Copy link
Member

steveisok commented May 5, 2021

As part of the cleanup work in #45741, we should rename the crypto library on Android since it does not have anything to do w/ OpenSSL.

Name of library: System.Security.Cryptography.Native.Android

You'll know it's right by checking the file in $(RepoRoot)/artifacts/bin/mono/./ is named libSystem.Security.Cryptography.Native.Android.a

Note on osx / linux, we prepend lib to the file name.

The rename starts at

# TODO: Use "System.Security.Cryptography.Native.Android" name (will require a lot of csproj changes here and there)
set_target_properties(System.Security.Cryptography.Native.Android PROPERTIES OUTPUT_NAME "System.Security.Cryptography.Native.OpenSsl")
set_target_properties(System.Security.Cryptography.Native.Android-Static PROPERTIES OUTPUT_NAME "System.Security.Cryptography.Native.OpenSsl")
and will likely need to be modified elsewhere.

Another important place is here

System.loadLibrary("System.Security.Cryptography.Native.OpenSsl");

@ghost
Copy link

ghost commented May 5, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As part of the cleanup work in #45741, we should rename the crypto library on Android since it does not have anything to do w/ OpenSSL.

The rename starts at

# TODO: Use "System.Security.Cryptography.Native.Android" name (will require a lot of csproj changes here and there)
set_target_properties(System.Security.Cryptography.Native.Android PROPERTIES OUTPUT_NAME "System.Security.Cryptography.Native.OpenSsl")
set_target_properties(System.Security.Cryptography.Native.Android-Static PROPERTIES OUTPUT_NAME "System.Security.Cryptography.Native.OpenSsl")
and will likely need to be modified elsewhere.

Another important place is here

System.loadLibrary("System.Security.Cryptography.Native.OpenSsl");

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono, os-android

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 5, 2021
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label May 5, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 6, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants