Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Handle multiple python directories in emsdk #51746

Open
radekdoulik opened this issue Apr 23, 2021 · 2 comments
Open

[wasm] Handle multiple python directories in emsdk #51746

radekdoulik opened this issue Apr 23, 2021 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Milestone
Future

Comments

@radekdoulik
Copy link
Member

Sometime emsdk can contain multiple versions of python or other tools. We use $([System.IO.Directory]::GetDirectories($(_PythonToolsBasePath))) to get the _PythonToolsVersionedPath and assume there is only one subdirectory present.

src\mono\wasm\build\WasmApp.targets(289,5): error : Specified Emscripten sdk at $(EMSDK_PATH)=C:\Users\rodo\git\emsdk\ is missing some paths: $(EmscriptenPythonToolsPath)=...\emsdk\python\3.7.4-pywin32_64bit;...\emsdk\python\3.9.2-1_64bit\ . Emscripten SDK is required for AOT'ing assemblies.
@radekdoulik radekdoulik added arch-wasm WebAssembly architecture area-Build-mono labels Apr 23, 2021
@ghost
Copy link

ghost commented Apr 23, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Sometime emsdk can contain multiple versions of python or other tools. We use $([System.IO.Directory]::GetDirectories($(_PythonToolsBasePath))) to get the _PythonToolsVersionedPath and assume there is only one subdirectory present.

src\mono\wasm\build\WasmApp.targets(289,5): error : Specified Emscripten sdk at $(EMSDK_PATH)=C:\Users\rodo\git\emsdk\ is missing some paths: $(EmscriptenPythonToolsPath)=...\emsdk\python\3.7.4-pywin32_64bit;...\emsdk\python\3.9.2-1_64bit\ . Emscripten SDK is required for AOT'ing assemblies.
Author: radekdoulik
Assignees: radical
Labels:

arch-wasm, area-Build-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 23, 2021
@lewing
Copy link
Member

lewing commented Apr 24, 2021

Yeah, I think we can improve how we handle the case when EMSDK_PATH is set.

@lewing lewing added this to the Future milestone Apr 27, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Apr 27, 2021
@ilonatommy ilonatommy mentioned this issue Jun 11, 2024
Merged
This was referenced Jun 26, 2024
Open
Closed
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 26, 2024
@radical radical removed their assignment Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Test HybridGlobalization with AOT on CI ilonatommy/runtime
3 participants
@radical @lewing @radekdoulik