Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding the build of NCL stress and enterprise tests to the mandatory legs of the CI #51120

Open
antonfirsov opened this issue Apr 12, 2021 · 3 comments

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Apr 12, 2021

Currently there is no CI guarantee to make sure these projects are not broken. PR #49706 fixed such a regression, but in a few weeks the build got broken again (#51117) with a reason that is far from being obvious.

We should consider running build-only variants of stress/http.yml, stress/ssl.yml and enterprise/linux.yml as a mandatory PR checks.

The lack of such an automation makes it really hard to keep these projects functional while the underlying infrastructure is being refactored.

cc @ViktorHofer

Edit 1: An alternative could be an agreement to run those pipelines on infrastructure changes.
Edit 2: The root cause of #51117 was a library bug (#51141) breaking the SDK, meaning that guarding the infra changes only might be insufficient, but this looks like an exceptional case.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 12, 2021
@ghost
Copy link

ghost commented Apr 12, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently there is no CI guarantee to make sure these projects are not broken. PR #49706 fixed such a regression, but in a few weeks the build got broken again (#51117) with a reason that is far from being obvious.

We should consider running build-only variants of stress/http.yml, stress/ssl.yml and enterprise/linux.yml as a mandatory PR checks.

The lack of such an automation makes it really hard to keep these projects functional while the underlying infrastructure is being refactored.

cc @ViktorHofer

Author: antonfirsov
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged

Milestone: -

@ViktorHofer
Copy link
Member

Some thoughts we just had during triaging:

  • We need to keep resources in mind (these are limited)
  • We don't want to run the tests on every CI, but just build the tests
  • Added complexity of docker containers?

Feel free to submit a PR to add the leg to build as part of CI. Will move this to future meanwhile.

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Apr 21, 2021
@ViktorHofer ViktorHofer added this to the Future milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants