TargetOS is case-sensitive for iOSSimulator when running tests

[CoffeeFlux]

./dotnet.sh build src/libraries/System.Threading.Timer/tests/ /t:test /p:targetos=iossimulator /p:targetarchitecture=x64 will fail, but ./dotnet.sh build src/libraries/System.Threading.Timer/tests/ /t:test /p:targetos=iOSSimulator /p:targetarchitecture=x64 will succeed. MSBuild otherwise isn't case-sensitive, so this should probably just be fixed.

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

./dotnet.sh build src/libraries/System.Threading.Timer/tests/ /t:test /p:targetos=iossimulator /p:targetarchitecture=x64 will fail, but ./dotnet.sh build src/libraries/System.Threading.Timer/tests/ /t:test /p:targetos=iOSSimulator /p:targetarchitecture=x64 will succeed. MSBuild otherwise isn't case-sensitive, so this should probably just be fixed.

Author:	CoffeeFlux
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[filipnavara]

Same for iOS. Got bitten by it.

[CoffeeFlux]

cc: @steveisok

[CoffeeFlux]

Yeah, msbuild is case-insensitive by default, which is why I expected that to hold here. In this case, it's failing due to what appears to be having to interface with cmake? Full log: https://gist.github.com/CoffeeFlux/c1e2d1f34c442b9fb4ff42a839a45d29

[steveisok]

I think it probably has everything to do w/ how we shuffle to cmake in AppleAppBuilder.

runtime/src/tasks/AppleAppBuilder/Xcode.cs

Line 181 in 60d169b

.Append(" -DCMAKE_SYSTEM_NAME=" + targetName)

runtime/src/tasks/AppleAppBuilder/Xcode.cs

Lines 158 to 174 in 60d169b

	switch (Target)
	{
	case TargetNames.MacCatalyst:
	targetName = "Darwin";
	break;
	case TargetNames.iOS:
	case TargetNames.iOSsim:
	targetName = "iOS";
	break;
	case TargetNames.tvOS:
	case TargetNames.tvOSsim:
	targetName = "tvOS";
	break;
	default:
	targetName = Target.ToString();
	break;
	}

[CoffeeFlux]

This issue persists, though the error has changed. New log: https://gist.github.com/CoffeeFlux/ebaac87f883ff0ffc36587c4bda25f3b

[MaximLipnin]

Thanks Ryan, I'll take a look.