-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate why StackFrameHelperTest Trimming test fails on mono #48849
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsPR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.
|
FYI: @marek-safar |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.
|
Is this the correct area label for this issue? |
This is an older issue, and we have had no known customer issues raised because of it. Closing until we have more feedback. |
PR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.
The text was updated successfully, but these errors were encountered: