Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why StackFrameHelperTest Trimming test fails on mono #48849

Closed
Tracked by #64603
joperezr opened this issue Feb 26, 2021 · 6 comments
Closed
Tracked by #64603

Investigate why StackFrameHelperTest Trimming test fails on mono #48849

joperezr opened this issue Feb 26, 2021 · 6 comments
Assignees
Labels
area-Diagnostics-mono runtime-mono specific to the Mono runtime
Milestone

Comments

@joperezr
Copy link
Member

PR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 26, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@joperezr joperezr added area-System.Diagnostics.Tracing runtime-mono specific to the Mono runtime and removed untriaged New issue has not been triaged by the area owner labels Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.

Author: joperezr
Assignees: -
Labels:

area-System.Diagnostics.Tracing, runtime-mono

Milestone: -

@joperezr
Copy link
Member Author

FYI: @marek-safar

@lewing lewing added the arch-wasm WebAssembly architecture label Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #48429 added the browser-wasm leg to our Trimming tests and this was the first time that our trimming tests would run against the mono runtime. One of the findings when analyzing the results was that the test StackFrameHelperTest was failing due to the fact that it wasn't able to retrieve the line information from a newly created StackTrace object. The test was disabled on that same PR due to the fact that the test's intention was actually to validate that a linker annotation was preserving the right methods in order for line information to be retrieved correctly, and this annotation was specific to coreclr's runtime, so it didn't make sense to run it on Mono. That said, we should take a look and see why line information isn't able to be retrieved when running on Mono in case this is not a known issue or by design.

Author: joperezr
Assignees: -
Labels:

arch-wasm, area-System.Runtime, runtime-mono

Milestone: -

@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 23, 2021
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Jul 31, 2021
@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@dakersnar dakersnar added area-Diagnostics-mono untriaged New issue has not been triaged by the area owner and removed area-System.Runtime labels Sep 29, 2022
@dakersnar
Copy link
Contributor

Is this the correct area label for this issue?

@lewing lewing removed arch-wasm WebAssembly architecture untriaged New issue has not been triaged by the area owner labels Sep 30, 2022
@steveisok steveisok modified the milestones: 8.0.0, 9.0.0 Aug 8, 2023
@tommcdon
Copy link
Member

tommcdon commented Apr 9, 2024

This is an older issue, and we have had no known customer issues raised because of it. Closing until we have more feedback.

@tommcdon tommcdon closed this as completed Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-mono runtime-mono specific to the Mono runtime
Projects
None yet
Development

No branches or pull requests

7 participants