Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building linker tests spawns hundreds of NuGet out-of-process restore executables #48027

Closed
ViktorHofer opened this issue Feb 9, 2021 · 1 comment · Fixed by #48429
Closed

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 9, 2021

When building linker tests, NuGet is invoked per generated linker test project which a) performs poorly and b) is a can for NuGet instability issues. We should usually only invoke NuGet once for all projects as we do for all other projects in dotnet/runtime (besides for tasks).

This is achievable via a wrapper project that defines dependencies via P2Ps to all the generated linker projects. That wrapper project file already exists today (tests.proj). Generating the linker projects would need to happen before tests.proj is restored so that the dependencies are defined "statically".

cc @joperezr @eerhardt

@ghost
Copy link

ghost commented Feb 9, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

When building linker tests, NuGet is invoked per generated linker test project which a) performs poorly and b) is a can for NuGet instability issues. We should usually only invoke NuGet once for all projects as we do for all other projects in dotnet/runtime (besides for tasks).

This is achievable via a wrapper project that defines dependencies via P2Ps to all the generated linker projects. That wrapper project file already exists today (tests.proj). Generating the linker projects would need to happen before tests.proj is restored so that the dependencies can be defined in-time.

cc @joperezr @eerhardt

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 9, 2021
@ViktorHofer ViktorHofer added this to the Future milestone Feb 23, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 24, 2021
@ghost ghost closed this as completed in #48429 Feb 27, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant