Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreclr.dll size regressed ~200kB due to constexpr changes #39599

Closed
jkotas opened this issue Jul 18, 2020 · 4 comments · Fixed by #40282
Closed

coreclr.dll size regressed ~200kB due to constexpr changes #39599

jkotas opened this issue Jul 18, 2020 · 4 comments · Fixed by #40282
Assignees
@janvorli
Labels
area-VM-coreclr tenet-performance Performance related issue
Milestone
5.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Jul 18, 2020 •
edited
Loading

#39532 introduce unexpected ~200kB size regression in coreclr.dll size on Windows x64:

commit a9b0beb

5,028,352 coreclr.dll

commit 9026457

5,209,600 coreclr.dll
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 18, 2020
@jkotas
Copy link
Member Author

jkotas commented Jul 18, 2020

It may be best to just move to the constant data to .cpp where possible. It seems to be the only full portable and reliable way to avoid the constant duplication.

#39532 (comment)

@jkotas jkotas added area-VM-coreclr tenet-performance Performance related issue labels Jul 18, 2020
@jkotas jkotas added this to the 5.0.0 milestone Jul 18, 2020
@jkotas jkotas mentioned this issue Jul 18, 2020
Merged
@jkotas jkotas changed the title coreclr.dll size regressed ~200kB coreclr.dll size regressed ~200kB due to constexpr changes Jul 18, 2020
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jul 20, 2020
@mangod9
Copy link
Member

mangod9 commented Jul 22, 2020

Assume this means we have to conditionally compile using constexpr only on Linux?

@jkotas
Copy link
Member Author

jkotas commented Jul 22, 2020

Or move the static data to the .cpp files and stop depending on these fancy features that do not work...

@AustinWise AustinWise mentioned this issue Aug 3, 2020
Merged
@janvorli janvorli mentioned this issue Aug 3, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@janvorli janvorli

Labels
area-VM-coreclr tenet-performance Performance related issue
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix Windows coreclr.dll size regression janvorli/runtime
4 participants
@jkotas @janvorli @Dotnet-GitSync-Bot @mangod9