[QUIC] Improve MSQuic OS Version detection

[Tratcher]

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/MsQuicApi.cs

Lines 144 to 146 in 3be5238

	OperatingSystem ver = Environment.OSVersion;
	if (ver.Platform == PlatformID.Win32NT && ver.Version < new Version(10, 0, 19041, 0))

Environment.OSVersion is an unreliable API that reports old versions for compat purposes. It only reports the correct Win10 version if an app manifest is added. VS and the test runner have this manifest but sample apps and customer apps won't.
https://stackoverflow.com/questions/33328739/system-environment-osversion-returns-wrong-version

We're going to need a different way to check for this support. Worst case we look at the registry.

[am11]

fwiw, dotnet-cli uses this property for dotnet --info, which I think does not rely on the app manifest:

runtime/src/installer/managed/Microsoft.DotNet.PlatformAbstractions/RuntimeEnvironment.cs

Line 16 in cf43585

public static string OperatingSystemVersion { get; } = PlatformApis.GetOSVersion();

[jkotas]

Microsoft.DotNet.PlatformAbstractions package is obsolete.

P/Invoking Ntdll.RtlGetVersionEx is your best bet.

[jkotas]

It only reports the correct Win10 version if an app manifest is added. VS and the test runner have this manifest but sample apps and customer apps won't.

This is considered to be a feature. It is not necessary something you want to "fix".

[am11]

Microsoft.DotNet.PlatformAbstractions package is obsolete.

will its sources be removed and dotnet-cli switch to p/invoke?

Edit: nvm, found the issue tracking it - #3470

[Tratcher]

This is considered to be a feature. It is not necessary something you want to "fix".

This version check is to see if the OS has the right TLS 1.3 support. Http3 will have other opt-in guards to maintain compat. Once a developer opts in, false negatives from this version check are an unnecessary hurdle and support burden.

[Tratcher]

#33643 fixed Environment.OSVersion so we can depend on that again.

[eerhardt]

@Tratcher - do you want me to update #36302 to add back the Environment.OSVersion check?

[Tratcher]

@jkotalik have you confirmed which version we need?

[jkotalik]

No, let's just merge what we have in that #36302 for now. I'll need to figure out if the Windows slow preview train has schannel support, which will take a while.

[scalablecory]

I'm thinking it's better to implement this in MsQuic -- microsoft/msquic#92

[ManickaP]

This can be covered by analyzers with SupportedOSPlatform, first crude draft is already in #49261, we just need a complete list of supported OS/versions/distros.

edit:
This will not help with checking the minimal Windows version. However, that should be a one-liner in S.N.Quic initialization: https://docs.microsoft.com/en-us/dotnet/api/system.operatingsystem.iswindowsversionatleast?view=net-5.0.