Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionConverter and UriTypeConverter inconsistent behavior wrt full framework #30085

Closed
safern opened this issue Jun 28, 2019 · 3 comments · Fixed by dotnet/corefx#39203
Closed

VersionConverter and UriTypeConverter inconsistent behavior wrt full framework #30085

safern opened this issue Jun 28, 2019 · 3 comments · Fixed by dotnet/corefx#39203
Assignees
@Marusyk
Labels
area-System.ComponentModel help wanted [up-for-grabs] Good issue for external contributors
Milestone
3.0

Comments

@safern
Copy link
Member

safern commented Jun 28, 2019

Per @hughbe (dotnet/corefx#28516 (comment)):

Couple of things that I would like to point out that are inconsistent between UriTypeConverter/VersionConverter and the other type converters in .NET Core:

  • They throw ArgumentNullException for CanConvertFrom(null) whereas .NET Framework returns false. I suggest fixing this to be consistent with other type converters.
  • They return false for CanConvertFrom(typeof(InstanceDescriptor)) because they don't call their base class CanConvertFrom method. See Adhere to desktop implementation of [Can]ConvertFrom corefx#35760. I suggest fixing this
  • They don't support InstanceDescriptor conversion - should this be added to VersionConverter?
@Marusyk
Copy link
Member

Marusyk commented Jul 4, 2019

Can I try to prepare PR for this?

@safern
Copy link
Member Author

safern commented Jul 4, 2019

Yes. If you’re going to take it this would need to be ready before July 16th. Let me know to assign it.

@Marusyk
Copy link
Member

Marusyk commented Jul 4, 2019

Yes, I will prepare PR until Monday

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 3.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Marusyk Marusyk

Labels
area-System.ComponentModel help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix inconsistent behavior in VersionConverter and UriTypeConverter with full framework
3 participants
@Marusyk @msftgits @safern