Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests do not run under netfx targetgroup #27157

Closed
maryamariyan opened this issue Aug 16, 2018 · 1 comment
Closed

Performance tests do not run under netfx targetgroup #27157

maryamariyan opened this issue Aug 16, 2018 · 1 comment
Assignees
Milestone

Comments

@maryamariyan
Copy link
Member

Seems like we don't support running perf tests in netfx.

For example when running:

msbuild src\System.IO.Compression\tests\Performance\ /t:rebuildandtest /p:ConfigurationGroup=Release /p:TargetOs=Windows_NT /p:Performance=true /p:targetgroup=netfx

it just ends up running with default targetgroup (being netcoreapp)

Although there are other ways (e.g. using BenchmarkDotnet) to do performance testing in netfx, it could still be useful to enable this in cases when we want to compare netfx vs netcoreapp performances with each other for the existing perf tests written in corefx.

Note: When trying to test the above script I believe you need to add netfx value in the configuration.props file here.

cc: @danmosemsft @safern

@ViktorHofer
Copy link
Member

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants