You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
__TestBuildMode: crossgen2 (as in git grep __TestBuildMode.*crossgen2) should use helix so we can revert 2324602 (i.e. use published crossgen2.exe instead of dotnet crossgen2.dll)
Crossgen2Tool (as in git grep '<Crossgen2Tool' should similarly use published crossgen2.exe instead of crossgen2.dll and while working on it, we should deduplicate
Remove apphost.exe requirement from crossgen2_publish; some ResolveFrameworkRef.. type of target make it mandatory during the publish. It will allow us to delete this two-step workaround
Integrate src/tests/build.sh/cmd with top-level build.sh/cmd, so when we use build.sh -c release -rc checked, the corresponding test command is src/tests/build.sh -release -p:RuntimeConfiguration=checked instead of what we have now src/tests/build.sh -checked -p:LibrariesConfiguration=release. This will allow us to remove workaround like
<_apphostPathCondition="'$(_apphostPath)' == '' and Exists('$(ArtifactsBinDir)$(_targetOS)-$(TargetArchitecture).$(LibrariesConfiguration)\corehost\apphost$(ExeSuffix)')">$(ArtifactsBinDir)$(_targetOS)-$(TargetArchitecture).$(LibrariesConfiguration)\corehost\apphost$(ExeSuffix)</_apphostPath>
#80154 followups:
__TestBuildMode: crossgen2
(as ingit grep __TestBuildMode.*crossgen2
) should use helix so we can revert 2324602 (i.e. use published crossgen2.exe instead ofdotnet crossgen2.dll
)Crossgen2Tool
(as ingit grep '<Crossgen2Tool'
should similarly use published crossgen2.exe instead of crossgen2.dll and while working on it, we should deduplicateand
Remove apphost.exe requirement from crossgen2_publish; some
ResolveFrameworkRef..
type of target make it mandatory during the publish. It will allow us to delete this two-step workaroundruntime/src/tests/Common/Directory.Build.targets
Lines 59 to 64 in 62835af
Integrate
src/tests/build.sh/cmd
with top-levelbuild.sh/cmd
, so when we usebuild.sh -c release -rc checked
, the corresponding test command issrc/tests/build.sh -release -p:RuntimeConfiguration=checked
instead of what we have nowsrc/tests/build.sh -checked -p:LibrariesConfiguration=release
. This will allow us to remove workaround likeruntime/src/tests/Common/Directory.Build.targets
Lines 40 to 57 in 62835af
The text was updated successfully, but these errors were encountered: