Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit the usage of scoped in the Tensor APIs #102266

Closed
tannergooding opened this issue May 15, 2024 · 2 comments
Closed

Audit the usage of scoped in the Tensor APIs #102266

tannergooding opened this issue May 15, 2024 · 2 comments

Comments

@tannergooding
Copy link
Member

Work is being done to introduce a Tensor<T> and supporting types. As part of that, there are many APIs that are both taking in some ref or span like type and which also return a ref or span like type or which exist as instance methods on a span like type.

Most of these inputs will never be captured by the underlying or returned span like type and so should be annotated as scoped which restricts the lifetime of the inputs and effectively indicates that the lifetime won't be extended (and therefore won't be captured by a span like type or returned as a ref).

We should, accordingly, audit all the newly introduced APIs and ensure scoped is appropriately provided on the APIs where relevant.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 15, 2024
@tannergooding tannergooding added area-System.Numerics.Tensors and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 15, 2024
@tannergooding tannergooding added this to the 9.0.0 milestone May 15, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

@michaelgsharp
Copy link
Member

Closing as this has been done.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants