Skip to content

Commit ec28cb3

Browse files
authored
Reenable SocketsHttpHandlerTest_Http3_MsQuic.SendMoreThanStreamLimitRequestsConcurrently_LastWaits test (#67419)
1 parent 180df16 commit ec28cb3

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public async Task ClientSettingsReceived_Success(int headerSizeLimit)
8686
[InlineData(1000)]
8787
public async Task SendMoreThanStreamLimitRequests_Succeeds(int streamLimit)
8888
{
89-
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options(){ MaxBidirectionalStreams = streamLimit });
89+
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options() { MaxBidirectionalStreams = streamLimit });
9090

9191
Task serverTask = Task.Run(async () =>
9292
{
@@ -125,7 +125,7 @@ public async Task SendMoreThanStreamLimitRequests_Succeeds(int streamLimit)
125125
[InlineData(1000)]
126126
public async Task SendStreamLimitRequestsConcurrently_Succeeds(int streamLimit)
127127
{
128-
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options(){ MaxBidirectionalStreams = streamLimit });
128+
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options() { MaxBidirectionalStreams = streamLimit });
129129

130130
Task serverTask = Task.Run(async () =>
131131
{
@@ -169,7 +169,6 @@ public async Task SendStreamLimitRequestsConcurrently_Succeeds(int streamLimit)
169169
[InlineData(10)]
170170
[InlineData(100)]
171171
[InlineData(1000)]
172-
[ActiveIssue("https://github.com/dotnet/runtime/issues/55901")]
173172
public async Task SendMoreThanStreamLimitRequestsConcurrently_LastWaits(int streamLimit)
174173
{
175174
// This combination leads to a hang manifesting in CI only. Disabling it until there's more time to investigate.
@@ -179,7 +178,7 @@ public async Task SendMoreThanStreamLimitRequestsConcurrently_LastWaits(int stre
179178
return;
180179
}
181180

182-
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options(){ MaxBidirectionalStreams = streamLimit });
181+
using Http3LoopbackServer server = CreateHttp3LoopbackServer(new Http3Options() { MaxBidirectionalStreams = streamLimit });
183182
var lastRequestContentStarted = new TaskCompletionSource();
184183

185184
Task serverTask = Task.Run(async () =>
@@ -195,7 +194,8 @@ public async Task SendMoreThanStreamLimitRequestsConcurrently_LastWaits(int stre
195194
}
196195

197196
// Make the last request running independently.
198-
var lastRequest = Task.Run(async () => {
197+
var lastRequest = Task.Run(async () =>
198+
{
199199
using Http3LoopbackStream stream = await connection.AcceptRequestStreamAsync();
200200
await stream.HandleRequestAsync();
201201
});
@@ -416,7 +416,7 @@ public async Task RequestSendingResponseDisposed_ThrowsOnServer()
416416
RequestUri = server.Address,
417417
Version = HttpVersion30,
418418
VersionPolicy = HttpVersionPolicy.RequestVersionExact,
419-
Content = new ByteAtATimeContent(60*4, Task.CompletedTask, new TaskCompletionSource<bool>(), 250)
419+
Content = new ByteAtATimeContent(60 * 4, Task.CompletedTask, new TaskCompletionSource<bool>(), 250)
420420
};
421421

422422
var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead);
@@ -723,12 +723,12 @@ public async Task ResponseCancellation_ServerReceivesCancellation(CancellationTy
723723
using HttpClient client = CreateHttpClient();
724724

725725
using HttpRequestMessage request = new()
726-
{
727-
Method = HttpMethod.Get,
728-
RequestUri = server.Address,
729-
Version = HttpVersion30,
730-
VersionPolicy = HttpVersionPolicy.RequestVersionExact
731-
};
726+
{
727+
Method = HttpMethod.Get,
728+
RequestUri = server.Address,
729+
Version = HttpVersion30,
730+
VersionPolicy = HttpVersionPolicy.RequestVersionExact
731+
};
732732
HttpResponseMessage response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead).WaitAsync(TimeSpan.FromSeconds(10));
733733

734734
Stream stream = await response.Content.ReadAsStreamAsync();
@@ -785,7 +785,7 @@ public async Task ResponseCancellation_BothCancellationTokenAndDispose_Success()
785785

786786
HttpRequestData request = await stream.ReadRequestDataAsync().ConfigureAwait(false);
787787

788-
int contentLength = 2*1024*1024;
788+
int contentLength = 2 * 1024 * 1024;
789789
var headers = new List<HttpHeaderData>();
790790
headers.Append(new HttpHeaderData("Content-Length", contentLength.ToString(CultureInfo.InvariantCulture)));
791791

@@ -810,12 +810,12 @@ public async Task ResponseCancellation_BothCancellationTokenAndDispose_Success()
810810
using HttpClient client = CreateHttpClient();
811811

812812
using HttpRequestMessage request = new()
813-
{
814-
Method = HttpMethod.Get,
815-
RequestUri = server.Address,
816-
Version = HttpVersion30,
817-
VersionPolicy = HttpVersionPolicy.RequestVersionExact
818-
};
813+
{
814+
Method = HttpMethod.Get,
815+
RequestUri = server.Address,
816+
Version = HttpVersion30,
817+
VersionPolicy = HttpVersionPolicy.RequestVersionExact
818+
};
819819
HttpResponseMessage response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead).WaitAsync(TimeSpan.FromSeconds(20));
820820

821821
Stream stream = await response.Content.ReadAsStreamAsync();
@@ -917,12 +917,12 @@ public async Task Alpn_NonH3_NegotiationFailure()
917917
using HttpClient client = CreateHttpClient();
918918

919919
using HttpRequestMessage request = new()
920-
{
921-
Method = HttpMethod.Get,
922-
RequestUri = server.Address,
923-
Version = HttpVersion30,
924-
VersionPolicy = HttpVersionPolicy.RequestVersionExact
925-
};
920+
{
921+
Method = HttpMethod.Get,
922+
RequestUri = server.Address,
923+
Version = HttpVersion30,
924+
VersionPolicy = HttpVersionPolicy.RequestVersionExact
925+
};
926926

927927
HttpRequestException ex = await Assert.ThrowsAsync<HttpRequestException>(() => client.SendAsync(request).WaitAsync(TimeSpan.FromSeconds(10)));
928928
Assert.Contains("ALPN_NEG_FAILURE", ex.Message);
@@ -1057,7 +1057,7 @@ public async Task EchoServerStreaming_DifferentMessageSize_Success(int messageSi
10571057

10581058
var responseTask = client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead).WaitAsync(TimeSpan.FromSeconds(10));
10591059

1060-
Stream requestStream = await requestContent.GetStreamAsync().WaitAsync(TimeSpan.FromSeconds(10));;
1060+
Stream requestStream = await requestContent.GetStreamAsync().WaitAsync(TimeSpan.FromSeconds(10));
10611061
// Send headers
10621062
await requestStream.FlushAsync();
10631063

0 commit comments

Comments
 (0)