Convert all usages of target_link_libraries to use PUBLIC/PRIVATE specifiers (#81924)

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>

Author: jkoritzinsky

src/coreclr/debug/createdump/CMakeLists.txt

@@ -24,6 +24,7 @@ if(CLR_CMAKE_HOST_WIN32)
     )
 
     target_link_libraries(createdump
+        PRIVATE
         kernel32.lib
         ${STATIC_MT_CRT_LIB}
         advapi32.lib
@@ -83,6 +84,7 @@ else()
 endif(CLR_CMAKE_HOST_OSX)
 
     target_link_libraries(createdump
+        PRIVATE
         corguids
         dbgutil
         # share the PAL in the dac module

src/coreclr/dlls/mscordbi/CMakeLists.txt

@@ -90,7 +90,7 @@ if(CLR_CMAKE_HOST_WIN32)
         ${STATIC_MT_VCRT_LIB}
     )
 
-    target_link_libraries(mscordbi ${COREDBI_LIBRARIES})
+    target_link_libraries(mscordbi PRIVATE ${COREDBI_LIBRARIES})
 
 elseif(CLR_CMAKE_HOST_UNIX)
 
@@ -114,7 +114,7 @@ elseif(CLR_CMAKE_HOST_UNIX)
     # COREDBI_LIBRARIES is mentioned twice because ld is one pass linker and will not find symbols
     # if they are defined after they are used. Having all libs twice makes sure that ld will actually
     # find all symbols.
-    target_link_libraries(mscordbi ${COREDBI_LIBRARIES} ${COREDBI_LIBRARIES})
+    target_link_libraries(mscordbi PRIVATE ${COREDBI_LIBRARIES} ${COREDBI_LIBRARIES})
 
     add_dependencies(mscordbi mscordaccore)
 

src/coreclr/gc/CMakeLists.txt

@@ -106,7 +106,7 @@ convert_to_absolute_path(GC_SOURCES ${GC_SOURCES})
 
 add_library_clr(clrgc SHARED ${GC_SOURCES})
 add_dependencies(clrgc eventing_headers)
-target_link_libraries(clrgc ${GC_LINK_LIBRARIES})
+target_link_libraries(clrgc PRIVATE ${GC_LINK_LIBRARIES})
 install_clr(TARGETS clrgc DESTINATIONS . COMPONENT runtime)
 
 add_definitions(-DBUILD_AS_STANDALONE)

src/coreclr/gc/sample/CMakeLists.txt

@@ -63,5 +63,5 @@ add_executable_clr(gcsample
 )
 
 if(CLR_CMAKE_TARGET_WIN32)
-    target_link_libraries(gcsample ${GC_LINK_LIBRARIES})
+    target_link_libraries(gcsample PRIVATE ${GC_LINK_LIBRARIES})
 endif()

src/coreclr/hosts/corerun/CMakeLists.txt

@@ -19,6 +19,7 @@ add_executable_clr(corerun
 
 if(CLR_CMAKE_HOST_WIN32)
     target_link_libraries(corerun
+        PRIVATE
         advapi32.lib
         oleaut32.lib
         uuid.lib
@@ -27,13 +28,13 @@ if(CLR_CMAKE_HOST_WIN32)
         ${STATIC_MT_VCRT_LIB}
     )
 else(CLR_CMAKE_HOST_WIN32)
-    target_link_libraries(corerun ${CMAKE_DL_LIBS})
+    target_link_libraries(corerun PRIVATE ${CMAKE_DL_LIBS})
     # Required to expose symbols for global symbol discovery
-    target_link_libraries(corerun -rdynamic)
+    target_link_libraries(corerun PRIVATE -rdynamic)
 
     # Android implements pthread natively
     if(NOT CLR_CMAKE_TARGET_ANDROID)
-        target_link_libraries(corerun pthread)
+        target_link_libraries(corerun PRIVATE pthread)
     endif()
 endif(CLR_CMAKE_HOST_WIN32)
 

src/coreclr/hosts/coreshim/CMakeLists.txt

@@ -13,6 +13,7 @@ add_library_clr(CoreShim
 )
 
 target_link_libraries(CoreShim
+    PRIVATE
     utilcodestaticnohost
     advapi32.lib
     oleaut32.lib

src/coreclr/ilasm/CMakeLists.txt

@@ -109,6 +109,7 @@ endif(CLR_CMAKE_TARGET_WIN32)
 
 if(CLR_CMAKE_HOST_UNIX)
   target_link_libraries(ilasm
+    PRIVATE
     ${ILASM_LINK_LIBRARIES}
     utilcodestaticnohost
     mscorrc
@@ -118,6 +119,7 @@ if(CLR_CMAKE_HOST_UNIX)
   )
 else()
   target_link_libraries(ilasm
+    PRIVATE
     ${ILASM_LINK_LIBRARIES}
     ole32
     oleaut32

src/coreclr/ildasm/exe/CMakeLists.txt

@@ -99,6 +99,7 @@ endif(CLR_CMAKE_HOST_WIN32)
 
 if(CLR_CMAKE_HOST_UNIX)
     target_link_libraries(ildasm
+        PRIVATE
         ${ILDASM_LINK_LIBRARIES}
         mscorrc
         coreclrpal
@@ -107,6 +108,7 @@ if(CLR_CMAKE_HOST_UNIX)
     )
 else()
     target_link_libraries(ildasm
+        PRIVATE
         ${ILDASM_LINK_LIBRARIES}
         ole32
         oleaut32

src/coreclr/jit/CMakeLists.txt

@@ -565,6 +565,7 @@ function(add_jit jitName)
     set_property(TARGET ${jitName} APPEND_STRING PROPERTY LINK_DEPENDS ${JIT_EXPORTS_FILE})
 
     target_link_libraries(${jitName}
+        PRIVATE
         ${JIT_LINK_LIBRARIES}
         ${JIT_ARCH_LINK_LIBRARIES}
     )

src/coreclr/pal/src/CMakeLists.txt

@@ -273,6 +273,7 @@ if(CLR_CMAKE_TARGET_OSX)
   find_library(SECURITY Security)
   find_library(SYSTEM System)
   target_link_libraries(coreclrpal
+    PUBLIC
     ${COREFOUNDATION}
     ${CORESERVICES}
     ${SECURITY}
@@ -282,6 +283,7 @@ endif(CLR_CMAKE_TARGET_OSX)
 
 if(CLR_CMAKE_TARGET_FREEBSD)
   target_link_libraries(coreclrpal
+    PUBLIC
     pthread
     rt
     ${UNWIND_LIBS}
@@ -292,27 +294,30 @@ if(CLR_CMAKE_TARGET_LINUX)
   # On Android, we don't need to link with gcc_s, pthread and rt
   if(NOT CLR_CMAKE_TARGET_ANDROID)
     target_link_libraries(coreclrpal
+      PUBLIC
       gcc_s
       pthread
       rt
     )
   else(NOT CLR_CMAKE_TARGET_ANDROID)
     target_link_libraries(coreclrpal
+      PUBLIC
       ${ANDROID_GLOB}
       ${LZMA})
   endif(NOT CLR_CMAKE_TARGET_ANDROID)
 
   target_link_libraries(coreclrpal
+    PUBLIC
     dl
   )
 
   if(CLR_CMAKE_USE_SYSTEM_LIBUNWIND)
-    target_link_libraries(coreclrpal ${UNWIND_LIBS})
+    target_link_libraries(coreclrpal PUBLIC ${UNWIND_LIBS})
   endif(CLR_CMAKE_USE_SYSTEM_LIBUNWIND)
 
   # bundled libunwind requires using libucontext on alpine and x86 and ppc64le
   if(CLR_CMAKE_TARGET_ALPINE_LINUX AND (CLR_CMAKE_TARGET_ARCH_I386 OR CLR_CMAKE_TARGET_ARCH_POWERPC64))
-    target_link_libraries(coreclrpal ucontext)
+    target_link_libraries(coreclrpal PUBLIC ucontext)
   endif(CLR_CMAKE_TARGET_ALPINE_LINUX AND (CLR_CMAKE_TARGET_ARCH_I386 OR CLR_CMAKE_TARGET_ARCH_POWERPC64))
 
 endif(CLR_CMAKE_TARGET_LINUX)
@@ -324,6 +329,7 @@ if(CLR_CMAKE_TARGET_NETBSD)
   add_definitions(-D_KMEMUSER)
   find_library(KVM kvm)
   target_link_libraries(coreclrpal
+    PUBLIC
     pthread
     rt
     ${UNWIND}
@@ -333,6 +339,7 @@ endif(CLR_CMAKE_TARGET_NETBSD)
 
 if(CLR_CMAKE_TARGET_SUNOS)
   target_link_libraries(coreclrpal
+    PUBLIC
     pthread
     rt
   )