Skip to content

Commit

Permalink
Remove FlakyAppHostTests category in installer tests (#60354)
Browse files Browse the repository at this point in the history
The underlying issue was fixed: #53587
  • Loading branch information
akoeplinger authored Oct 18, 2021
1 parent 0586b15 commit d57ccc2
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 20 deletions.
16 changes: 0 additions & 16 deletions eng/pipelines/runtime-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -432,22 +432,6 @@ jobs:
# creator: dotnet-bot
# testRunNamePrefixSuffix: Mono_$(_BuildConfig)

# Run disabled installer tests on Linux x64
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: Release
platforms:
- Linux_x64
jobParameters:
nameSuffix: Installer_Tests
isOfficialBuild: ${{ variables.isOfficialBuild }}
buildArgs: -s clr+libs+host+packs -restore -build -test -c $(_BuildConfig) -lc Debug /p:PortableBuild=true /p:RunOnStaging=true
useContinueOnErrorDuringBuild: true
enablePublisTestResults: true
testResultsFormat: xunit
timeoutInMinutes: 90

#
# Build Browser_wasm, on windows, run console and browser tests
#
Expand Down
2 changes: 0 additions & 2 deletions src/installer/tests/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
<TestArchitectures>$(TargetArchitecture)</TestArchitectures>
<TestInfraTargetFramework>$(NetCoreAppToolCurrent)</TestInfraTargetFramework>
<TestRunnerAdditionalArguments>-notrait category=failing</TestRunnerAdditionalArguments>
<TestRunnerAdditionalArguments Condition="'$(RunOnStaging)' != 'true'">$(TestRunnerAdditionalArguments) -notrait category=FlakyAppHostTests</TestRunnerAdditionalArguments>
<TestRunnerAdditionalArguments Condition="'$(RunOnStaging)' == 'true'">$(TestRunnerAdditionalArguments) -trait category=FlakyAppHostTests</TestRunnerAdditionalArguments>
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace AppHost.Bundle.Tests
{
[Trait("category", "FlakyAppHostTests")]
public class BundleExtractToSpecificPath : BundleTestBase, IClassFixture<BundleExtractToSpecificPath.SharedTestState>
{
private SharedTestState sharedTestState;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace AppHost.Bundle.Tests
{
[Trait("category", "FlakyAppHostTests")]
public class SingleFileApiTests : BundleTestBase, IClassFixture<SingleFileSharedState>
{
private SingleFileSharedState sharedTestState;
Expand Down

0 comments on commit d57ccc2

Please sign in to comment.