Skip to content

Commit d515841

Browse files
authored
Fix for failing WebSocket deflate test on ARM (#52052)
Reducing the number of times Random.Next is called to improve runtime performance of test on ARM. Fixes #52031
1 parent 089717b commit d515841

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs

+2-8
Original file line numberDiff line numberDiff line change
@@ -421,12 +421,6 @@ public async Task ReceiveInvalidCompressedData()
421421
[MemberData(nameof(SupportedWindowBits))]
422422
public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBits)
423423
{
424-
if (PlatformDetection.IsArmOrArm64Process && (windowBits == 14 || windowBits == 15))
425-
{
426-
// https://github.com/dotnet/runtime/issues/52031
427-
return;
428-
}
429-
430424
MemoryStream stream = new();
431425
using WebSocket client = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
432426
{
@@ -440,11 +434,11 @@ public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBi
440434
int frameSize = 2 << windowBits;
441435

442436
byte[] message = new byte[frameSize * 10];
443-
Random random = new(0);
437+
new Random(0).NextBytes(message);
444438

445439
for (int i = 0; i < message.Length; ++i)
446440
{
447-
message[i] = (byte)random.Next(maxValue: 10);
441+
message[i] %= 10;
448442
}
449443

450444
await client.SendAsync(message, WebSocketMessageType.Binary, true, CancellationToken);

0 commit comments

Comments
 (0)