From 8fb2eb53f75971ce492f14bebb93ed7a236bcd6e Mon Sep 17 00:00:00 2001
From: Anton Firszov <Anton.Firszov@microsoft.com>
Date: Tue, 18 May 2021 21:22:32 +0200
Subject: [PATCH] HttpStress: also disable firewall for HTTP2 (#52643)

We decided that we need to rule out the Windows Firewall as a cause for further failure types documented in #42211.
---
 eng/pipelines/libraries/stress/http.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/eng/pipelines/libraries/stress/http.yml b/eng/pipelines/libraries/stress/http.yml
index 44e2b81258598..08b7611d21159 100644
--- a/eng/pipelines/libraries/stress/http.yml
+++ b/eng/pipelines/libraries/stress/http.yml
@@ -88,6 +88,13 @@ jobs:
     name: buildStress
     displayName: Build HttpStress
 
+    # Firewall is disabled for the test runs, since it can lead to unexpected TCP failures on CI machines, which are unrelated to the HTTP logic.
+    # See: https://github.com/dotnet/runtime/issues/50854
+  - powershell: |
+      Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled False
+    name: disableFirewall
+    displayName: Disable Firewall
+
   - powershell: |
       cd '$(httpStressProject)'
       $env:HTTPSTRESS_CLIENT_ARGS = "$env:HTTPSTRESS_CLIENT_ARGS -http 2.0"
@@ -96,13 +103,6 @@ jobs:
     displayName: Run HttpStress - HTTP 2.0
     condition: and(eq(variables['buildRuntime.succeeded'], 'true'), eq(variables['buildStress.succeeded'], 'true'))
 
-    # Firewall is disabled for HTTP 1.1 runs.
-    # See: https://github.com/dotnet/runtime/issues/50854
-  - powershell: |
-      Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled False
-    name: disableFirewall
-    displayName: Disable Firewall
-
   - powershell: |
       cd '$(httpStressProject)'
       $env:HTTPSTRESS_CLIENT_ARGS = "$env:HTTPSTRESS_CLIENT_ARGS -http 1.1"