Simplify TryConvert for Half, Int128 and UInt128 (#116902)

jkotas · web-flow · commit 8234fe364914 · 2025-06-22T16:52:55.000-07:00
diff --git a/src/libraries/System.Private.CoreLib/src/System/Double.cs b/src/libraries/System.Private.CoreLib/src/System/Double.cs
@@ -1443,8 +1443,7 @@ private static bool TryConvertTo<TOther>(double value, [MaybeNullWhen(false)] ou
             }
             else if (typeof(TOther) == typeof(UInt128))
             {
-                UInt128 actualResult = (value >= 340282366920938463463374607431768211455.0) ? UInt128.MaxValue :
-                                       (value <= 0.0) ? UInt128.MinValue : (UInt128)value;
+                UInt128 actualResult = (UInt128)value;
                 result = (TOther)(object)actualResult;
                 return true;
             }
diff --git a/src/libraries/System.Private.CoreLib/src/System/Half.cs b/src/libraries/System.Private.CoreLib/src/System/Half.cs
@@ -2122,16 +2122,24 @@ private static bool TryConvertTo<TOther>(Half value, [MaybeNullWhen(false)] out
             }
             else if (typeof(TOther) == typeof(uint))
             {
+#if MONO
                 uint actualResult = (value == PositiveInfinity) ? uint.MaxValue :
                                     (value <= Zero) ? uint.MinValue : (uint)value;
+#else
+                uint actualResult = (uint)value;
+#endif
                 result = (TOther)(object)actualResult;
                 return true;
             }
             else if (typeof(TOther) == typeof(ulong))
             {
+#if MONO
                 ulong actualResult = (value == PositiveInfinity) ? ulong.MaxValue :
                                      (value <= Zero) ? ulong.MinValue :
                                      IsNaN(value) ? 0 : (ulong)value;
+#else
+                ulong actualResult = (ulong)value;
+#endif
                 result = (TOther)(object)actualResult;
                 return true;
             }
@@ -2144,8 +2152,12 @@ private static bool TryConvertTo<TOther>(Half value, [MaybeNullWhen(false)] out
             }
             else if (typeof(TOther) == typeof(nuint))
             {
+#if MONO
                 nuint actualResult = (value == PositiveInfinity) ? nuint.MaxValue :
                                      (value <= Zero) ? nuint.MinValue : (nuint)value;
+#else
+                nuint actualResult = (nuint)value;
+#endif
                 result = (TOther)(object)actualResult;
                 return true;
             }
diff --git a/src/libraries/System.Private.CoreLib/src/System/Int128.cs b/src/libraries/System.Private.CoreLib/src/System/Int128.cs
@@ -1580,15 +1580,13 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out Int128 re
             if (typeof(TOther) == typeof(double))
             {
                 double actualValue = (double)(object)value;
-                result = (actualValue >= +170141183460469231731687303715884105727.0) ? MaxValue :
-                         (actualValue <= -170141183460469231731687303715884105728.0) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
-                result = (actualValue == Half.PositiveInfinity) ? MaxValue :
-                         (actualValue == Half.NegativeInfinity) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
@@ -1624,8 +1622,7 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out Int128 re
             else if (typeof(TOther) == typeof(float))
             {
                 float actualValue = (float)(object)value;
-                result = (actualValue >= +170141183460469231731687303715884105727.0f) ? MaxValue :
-                         (actualValue <= -170141183460469231731687303715884105728.0f) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else
@@ -1655,15 +1652,13 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out Int128 re
             if (typeof(TOther) == typeof(double))
             {
                 double actualValue = (double)(object)value;
-                result = (actualValue >= +170141183460469231731687303715884105727.0) ? MaxValue :
-                         (actualValue <= -170141183460469231731687303715884105728.0) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
-                result = (actualValue == Half.PositiveInfinity) ? MaxValue :
-                         (actualValue == Half.NegativeInfinity) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
@@ -1699,8 +1694,7 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out Int128 re
             else if (typeof(TOther) == typeof(float))
             {
                 float actualValue = (float)(object)value;
-                result = (actualValue >= +170141183460469231731687303715884105727.0f) ? MaxValue :
-                         (actualValue <= -170141183460469231731687303715884105728.0f) ? MinValue : (Int128)actualValue;
+                result = (Int128)actualValue;
                 return true;
             }
             else
diff --git a/src/libraries/System.Private.CoreLib/src/System/Int32.cs b/src/libraries/System.Private.CoreLib/src/System/Int32.cs
@@ -1013,8 +1013,12 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out int resul
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? MaxValue :
                          (actualValue == Half.NegativeInfinity) ? MinValue : (int)actualValue;
+#else
+                result = (int)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
@@ -1099,8 +1103,12 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out int resul
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? MaxValue :
                          (actualValue == Half.NegativeInfinity) ? MinValue : (int)actualValue;
+#else
+                result = (int)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
diff --git a/src/libraries/System.Private.CoreLib/src/System/Int64.cs b/src/libraries/System.Private.CoreLib/src/System/Int64.cs
@@ -1010,8 +1010,12 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out long resu
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? MaxValue :
                          (actualValue == Half.NegativeInfinity) ? MinValue : (long)actualValue;
+#else
+                result = (long)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
@@ -1094,8 +1098,12 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out long resu
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? MaxValue :
                          (actualValue == Half.NegativeInfinity) ? MinValue : (long)actualValue;
+#else
+                result = (long)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
diff --git a/src/libraries/System.Private.CoreLib/src/System/IntPtr.cs b/src/libraries/System.Private.CoreLib/src/System/IntPtr.cs
@@ -1005,8 +1005,12 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out nint resu
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? unchecked((nint)nint_t.MaxValue) :
                          (actualValue == Half.NegativeInfinity) ? unchecked((nint)nint_t.MinValue) : (nint)actualValue;
+#else
+                result = (nint)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
@@ -1090,8 +1094,12 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out nint resu
             else if (typeof(TOther) == typeof(Half))
             {
                 Half actualValue = (Half)(object)value;
+#if MONO
                 result = (actualValue == Half.PositiveInfinity) ? unchecked((nint)nint_t.MaxValue) :
                          (actualValue == Half.NegativeInfinity) ? unchecked((nint)nint_t.MinValue) : (nint)actualValue;
+#else
+                result = (nint)actualValue;
+#endif
                 return true;
             }
             else if (typeof(TOther) == typeof(short))
diff --git a/src/libraries/System.Private.CoreLib/src/System/Single.cs b/src/libraries/System.Private.CoreLib/src/System/Single.cs
@@ -1462,8 +1462,7 @@ private static bool TryConvertTo<TOther>(float value, [MaybeNullWhen(false)] out
             }
             else if (typeof(TOther) == typeof(UInt128))
             {
-                UInt128 actualResult = (value == PositiveInfinity) ? UInt128.MaxValue :
-                                       (value <= 0.0f) ? UInt128.MinValue : (UInt128)value;
+                UInt128 actualResult = (UInt128)value;
                 result = (TOther)(object)actualResult;
                 return true;
             }

Original file line number	Diff line number	Diff line change
`@@ -1443,8 +1443,7 @@ private static bool TryConvertTo<TOther>(double value, [MaybeNullWhen(false)] ou`
`1443`	`1443`	`}`
`1444`	`1444`	`else if (typeof(TOther) == typeof(UInt128))`
`1445`	`1445`	`{`
`1446`		`- UInt128 actualResult = (value >= 340282366920938463463374607431768211455.0) ? UInt128.MaxValue :`
`1447`		`- (value <= 0.0) ? UInt128.MinValue : (UInt128)value;`
	`1446`	`+ UInt128 actualResult = (UInt128)value;`
`1448`	`1447`	`result = (TOther)(object)actualResult;`
`1449`	`1448`	`return true;`
`1450`	`1449`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2122,16 +2122,24 @@ private static bool TryConvertTo<TOther>(Half value, [MaybeNullWhen(false)] out`
`2122`	`2122`	`}`
`2123`	`2123`	`else if (typeof(TOther) == typeof(uint))`
`2124`	`2124`	`{`
	`2125`	`+#if MONO`
`2125`	`2126`	`uint actualResult = (value == PositiveInfinity) ? uint.MaxValue :`
`2126`	`2127`	`(value <= Zero) ? uint.MinValue : (uint)value;`
	`2128`	`+#else`
	`2129`	`+ uint actualResult = (uint)value;`
	`2130`	`+#endif`
`2127`	`2131`	`result = (TOther)(object)actualResult;`
`2128`	`2132`	`return true;`
`2129`	`2133`	`}`
`2130`	`2134`	`else if (typeof(TOther) == typeof(ulong))`
`2131`	`2135`	`{`
	`2136`	`+#if MONO`
`2132`	`2137`	`ulong actualResult = (value == PositiveInfinity) ? ulong.MaxValue :`
`2133`	`2138`	`(value <= Zero) ? ulong.MinValue :`
`2134`	`2139`	`IsNaN(value) ? 0 : (ulong)value;`
	`2140`	`+#else`
	`2141`	`+ ulong actualResult = (ulong)value;`
	`2142`	`+#endif`
`2135`	`2143`	`result = (TOther)(object)actualResult;`
`2136`	`2144`	`return true;`
`2137`	`2145`	`}`
`@@ -2144,8 +2152,12 @@ private static bool TryConvertTo<TOther>(Half value, [MaybeNullWhen(false)] out`
`2144`	`2152`	`}`
`2145`	`2153`	`else if (typeof(TOther) == typeof(nuint))`
`2146`	`2154`	`{`
	`2155`	`+#if MONO`
`2147`	`2156`	`nuint actualResult = (value == PositiveInfinity) ? nuint.MaxValue :`
`2148`	`2157`	`(value <= Zero) ? nuint.MinValue : (nuint)value;`
	`2158`	`+#else`
	`2159`	`+ nuint actualResult = (nuint)value;`
	`2160`	`+#endif`
`2149`	`2161`	`result = (TOther)(object)actualResult;`
`2150`	`2162`	`return true;`
`2151`	`2163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1580,15 +1580,13 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out Int128 re`
`1580`	`1580`	`if (typeof(TOther) == typeof(double))`
`1581`	`1581`	`{`
`1582`	`1582`	`double actualValue = (double)(object)value;`
`1583`		`- result = (actualValue >= +170141183460469231731687303715884105727.0) ? MaxValue :`
`1584`		`- (actualValue <= -170141183460469231731687303715884105728.0) ? MinValue : (Int128)actualValue;`
	`1583`	`+ result = (Int128)actualValue;`
`1585`	`1584`	`return true;`
`1586`	`1585`	`}`
`1587`	`1586`	`else if (typeof(TOther) == typeof(Half))`
`1588`	`1587`	`{`
`1589`	`1588`	`Half actualValue = (Half)(object)value;`
`1590`		`- result = (actualValue == Half.PositiveInfinity) ? MaxValue :`
`1591`		`- (actualValue == Half.NegativeInfinity) ? MinValue : (Int128)actualValue;`
	`1589`	`+ result = (Int128)actualValue;`
`1592`	`1590`	`return true;`
`1593`	`1591`	`}`
`1594`	`1592`	`else if (typeof(TOther) == typeof(short))`
`@@ -1624,8 +1622,7 @@ private static bool TryConvertFromSaturating<TOther>(TOther value, out Int128 re`
`1624`	`1622`	`else if (typeof(TOther) == typeof(float))`
`1625`	`1623`	`{`
`1626`	`1624`	`float actualValue = (float)(object)value;`
`1627`		`- result = (actualValue >= +170141183460469231731687303715884105727.0f) ? MaxValue :`
`1628`		`- (actualValue <= -170141183460469231731687303715884105728.0f) ? MinValue : (Int128)actualValue;`
	`1625`	`+ result = (Int128)actualValue;`
`1629`	`1626`	`return true;`
`1630`	`1627`	`}`
`1631`	`1628`	`else`
`@@ -1655,15 +1652,13 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out Int128 re`
`1655`	`1652`	`if (typeof(TOther) == typeof(double))`
`1656`	`1653`	`{`
`1657`	`1654`	`double actualValue = (double)(object)value;`
`1658`		`- result = (actualValue >= +170141183460469231731687303715884105727.0) ? MaxValue :`
`1659`		`- (actualValue <= -170141183460469231731687303715884105728.0) ? MinValue : (Int128)actualValue;`
	`1655`	`+ result = (Int128)actualValue;`
`1660`	`1656`	`return true;`
`1661`	`1657`	`}`
`1662`	`1658`	`else if (typeof(TOther) == typeof(Half))`
`1663`	`1659`	`{`
`1664`	`1660`	`Half actualValue = (Half)(object)value;`
`1665`		`- result = (actualValue == Half.PositiveInfinity) ? MaxValue :`
`1666`		`- (actualValue == Half.NegativeInfinity) ? MinValue : (Int128)actualValue;`
	`1661`	`+ result = (Int128)actualValue;`
`1667`	`1662`	`return true;`
`1668`	`1663`	`}`
`1669`	`1664`	`else if (typeof(TOther) == typeof(short))`
`@@ -1699,8 +1694,7 @@ private static bool TryConvertFromTruncating<TOther>(TOther value, out Int128 re`
`1699`	`1694`	`else if (typeof(TOther) == typeof(float))`
`1700`	`1695`	`{`
`1701`	`1696`	`float actualValue = (float)(object)value;`
`1702`		`- result = (actualValue >= +170141183460469231731687303715884105727.0f) ? MaxValue :`
`1703`		`- (actualValue <= -170141183460469231731687303715884105728.0f) ? MinValue : (Int128)actualValue;`
	`1697`	`+ result = (Int128)actualValue;`
`1704`	`1698`	`return true;`
`1705`	`1699`	`}`
`1706`	`1700`	`else`
Original file line number	Diff line number	Diff line change
`@@ -1462,8 +1462,7 @@ private static bool TryConvertTo<TOther>(float value, [MaybeNullWhen(false)] out`
`1462`	`1462`	`}`
`1463`	`1463`	`else if (typeof(TOther) == typeof(UInt128))`
`1464`	`1464`	`{`
`1465`		`- UInt128 actualResult = (value == PositiveInfinity) ? UInt128.MaxValue :`
`1466`		`- (value <= 0.0f) ? UInt128.MinValue : (UInt128)value;`
	`1465`	`+ UInt128 actualResult = (UInt128)value;`
`1467`	`1466`	`result = (TOther)(object)actualResult;`
`1468`	`1467`	`return true;`
`1469`	`1468`	`}`