[System.DirectoryServices.Protocols] Fix overflow in ProtocolVersion on Big Endian

medhatiwari · medhatiwari · commit 7a4ba9eea5b1 · 2025-02-11T07:25:06.000+01:00
diff --git a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs
@@ -4,6 +4,7 @@
 using System.ComponentModel;
 using System.IO;
 using System.Runtime.Versioning;
+using System.Buffers.Binary;
 
 namespace System.DirectoryServices.Protocols
 {
@@ -57,8 +58,9 @@ public bool SecureSocketLayer
 
         public int ProtocolVersion
         {
-            get => GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION).ToInt32();
-            set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, new IntPtr(value));
+            get => BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(BinaryPrimitives.ReadIntPtrLittleEndian(BitConverter.GetBytes(GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION))).ToInt32()));
+
+            set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, BinaryPrimitives.ReadIntPtrLittleEndian(BitConverter.GetBytes(new IntPtr(BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(value))))));
         }
 
         public ReferralChasingOptions ReferralChasing

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`using System.ComponentModel;`
`5`	`5`	`using System.IO;`
`6`	`6`	`using System.Runtime.Versioning;`
	`7`	`+using System.Buffers.Binary;`
`7`	`8`
`8`	`9`	`namespace System.DirectoryServices.Protocols`
`9`	`10`	`{`
`@@ -57,8 +58,9 @@ public bool SecureSocketLayer`
`57`	`58`
`58`	`59`	`public int ProtocolVersion`
`59`	`60`	`{`
`60`		`- get => GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION).ToInt32();`
`61`		`- set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, new IntPtr(value));`
	`61`	`+ get => BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(BinaryPrimitives.ReadIntPtrLittleEndian(BitConverter.GetBytes(GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION))).ToInt32()));`
	`62`	`+`
	`63`	`+ set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, BinaryPrimitives.ReadIntPtrLittleEndian(BitConverter.GetBytes(new IntPtr(BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(value))))));`
`62`	`64`	`}`
`63`	`65`
`64`	`66`	`public ReferralChasingOptions ReferralChasing`