Skip to content

Commit 7907943

Browse files
committed
copy cDAC instead of adding it to sharedFramework
1 parent 0f7a702 commit 7907943

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

eng/pipelines/runtime-diagnostics.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,12 @@ extends:
4646
isOfficialBuild: ${{ variables.isOfficialBuild }}
4747
timeoutInMinutes: 360
4848
postBuildSteps:
49+
# The cDAC is not included in the runtime pack, so we need to copy it into the testhost directory
4950
- powershell: |
51+
$cdacPath = Get-ChildItem -Path "$(Build.SourcesDirectory)\artifacts\bin\coreclr\*\mscordaccore_universal.dll" | Select-Object -ExpandProperty FullName
52+
$outputDacDir = Get-ChildItem -Directory -Path "$(Build.SourcesDirectory)\artifacts\bin\testhost\net*\shared\Microsoft.NETCore.App\*" | Select-Object -ExpandProperty FullName
53+
Copy-Item $cdacPath -Destination $outputDacDir
54+
Write-Host "Copied $cdacPath to $outputDacDir"
5055
$versionDir = Get-ChildItem -Directory -Path "$(Build.SourcesDirectory)\artifacts\bin\testhost\net*\shared\Microsoft.NETCore.App" | Select-Object -ExpandProperty FullName
5156
Write-Host "##vso[task.setvariable variable=versionDir]$versionDir"
5257
displayName: 'Set Path to Shared Framework Artifacts'

src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,6 @@
115115
<PlatformManifestFileEntry Condition="'$(PgoInstrument)' != ''" Include="clrjit.pgd" IsNative="true" />
116116
<PlatformManifestFileEntry Include="libclrjit.so" IsNative="true" />
117117
<PlatformManifestFileEntry Include="libclrjit.dylib" IsNative="true" />
118-
<PlatformManifestFileEntry Include="mscordaccore_universal.dll" IsNative="true" />
119-
<PlatformManifestFileEntry Include="libmscordaccore_universal.so" IsNative="true" />
120-
<PlatformManifestFileEntry Include="libmscordaccore_universal.dylib" IsNative="true" />
121118
<PlatformManifestFileEntry Include="mscordaccore.dll" IsNative="true" />
122119
<PlatformManifestFileEntry Include="libmscordaccore.so" IsNative="true" />
123120
<PlatformManifestFileEntry Include="libmscordaccore.dylib" IsNative="true" />

src/native/managed/cdac/mscordaccore_universal/mscordaccore_universal.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
</ItemGroup>
2828
<ItemGroup>
2929
<InstallRuntimeComponentDestination Include="." />
30-
<InstallRuntimeComponentDestination Include="sharedFramework" Condition="'$(RuntimeFlavor)' == 'coreclr'"/>
30+
<!-- TODO: [cdac] Output to sharedFramework and add PlatformManifestFileEntry for Microsoft.NETCore.App once ready to include in shipping package -->
31+
<!-- <InstallRuntimeComponentDestination Include="sharedFramework" Condition="'$(RuntimeFlavor)' == 'coreclr'"/> -->
3132
</ItemGroup>
3233

3334
<ItemGroup>

0 commit comments

Comments
 (0)