Cleanup some macro definitions in PAL (#119427)

* Use HOST_64BIT

* Cleanup __int64 definition

* _tfopen

* Consolidate NOINLINE definitions

* FORCEINLINE

* Cleanup __forceinline usages

* __UNREACHABLE

* Unused defines

* Number literal helpers

* DECLSPEC_ALIGN

* Unused

* Use offsetof from stddef

* Macros from palrt

* HWND

* MsgBox

* Misc unused

* Unify LL numeric suffix

* More unused mstypes

* Title-case OffsetOf is unused

* Cleanup raw __UNREACHABLE

* Unify unreachable with assert

* Handle assert conflict

---------

Co-authored-by: Jan Kotas <[email protected]>

Author: huoyaoyuan

src/coreclr/debug/di/rsmain.cpp

@@ -1646,7 +1646,7 @@ HRESULT Cordb::CreateProcessCommon(ICorDebugRemoteTarget * pRemoteTarget,
                 break;
 
             default:
-                __assume(0);
+                UNREACHABLE();
         }
 
     #endif // FEATURE_INTEROP_DEBUGGING

src/coreclr/debug/ee/debugger.cpp

@@ -8643,12 +8643,16 @@ int Debugger::NotifyUserOfFault(bool userBreakpoint, DebuggerLaunchSetting dls)
         if (userBreakpoint)
         {
             msg = "Application has encountered a user-defined breakpoint.\n\nProcess ID=0x%x (%d), Thread ID=0x%x (%d).\n\nClick ABORT to terminate the application.\nClick RETRY to debug the application.\nClick IGNORE to ignore the breakpoint.";
+#ifdef HOST_WINDOWS
             flags |= MB_ABORTRETRYIGNORE | MB_ICONEXCLAMATION;
+#endif
         }
         else
         {
             msg = "Application has generated an exception that could not be handled.\n\nProcess ID=0x%x (%d), Thread ID=0x%x (%d).\n\nClick OK to terminate the application.\nClick CANCEL to debug the application.";
+#ifdef HOST_WINDOWS
             flags |= MB_OKCANCEL | MB_ICONEXCLAMATION;
+#endif
         }
 
         // Format message string using optional parameters

src/coreclr/debug/ee/debuggermessagebox.cpp

@@ -34,10 +34,12 @@ static void DbgPrintf(const LPCSTR szFormat, ...)
     }
 }
 
+#ifndef HOST_UNIX
 typedef int (*MessageBoxWFnPtr)(HWND hWnd,
                                 LPCWSTR lpText,
                                 LPCWSTR lpCaption,
                                 UINT uType);
+#endif // !HOST_UNIX
 
 static int MessageBoxImpl(
                   LPCWSTR title,        // Dialog box title
@@ -157,10 +159,12 @@ int NotifyUserOfFaultMessageBox(
 
     int result = IDCANCEL;
 
+#ifdef HOST_WINDOWS
     // Add the MB_TASKMODAL style to indicate that the dialog should be displayed on top of the windows
     // owned by the current thread and should prevent interaction with them until dismissed.
     // Include in the MB_DEFAULT_DESKTOP_ONLY style.
     uType |= (MB_TASKMODAL | MB_DEFAULT_DESKTOP_ONLY);
+#endif
 
     EX_TRY
     {

src/coreclr/gc/env/gcenv.base.h

@@ -21,23 +21,8 @@
 
 #ifndef _MSC_VER
 #define __stdcall
-#ifdef __GNUC__
-#define __forceinline __attribute__((always_inline)) inline
-#else // __GNUC__
-#define __forceinline inline
-#endif // __GNUC__
-// [LOCALGC TODO] is there a better place for this?
-#define NOINLINE __attribute__((noinline))
-#else // !_MSC_VER
-#define NOINLINE __declspec(noinline)
 #endif // _MSC_VER
 
-#ifdef _MSC_VER
-#define __UNREACHABLE() __assume(0)
-#else
-#define __UNREACHABLE() __builtin_unreachable()
-#endif
-
 #ifndef SIZE_T_MAX
 #define SIZE_T_MAX ((size_t)-1)
 #endif
@@ -88,7 +73,6 @@ inline HRESULT HRESULT_FROM_WIN32(unsigned long x)
 #define FALSE false
 
 #define CALLBACK __stdcall
-#define FORCEINLINE __forceinline
 
 #define INFINITE 0xFFFFFFFF
 
@@ -103,12 +87,6 @@ inline HRESULT HRESULT_FROM_WIN32(unsigned long x)
   snprintf(string, sizeInBytes, format, ## __VA_ARGS__)
 #endif
 
-#ifdef UNICODE
-#define _tfopen _wfopen
-#else
-#define _tfopen fopen
-#endif
-
 #define WINAPI __stdcall
 
 typedef DWORD (WINAPI *PTHREAD_START_ROUTINE)(void* lpThreadParameter);
@@ -448,19 +426,12 @@ typedef DPTR(uint8_t)   PTR_uint8_t;
 #define DATA_ALIGNMENT sizeof(uintptr_t)
 #define RAW_KEYWORD(x) x
 
-#ifdef _MSC_VER
-#define DECLSPEC_ALIGN(x)   __declspec(align(x))
-#else
-#define DECLSPEC_ALIGN(x)   __attribute__((aligned(x)))
-#endif
-
 #ifndef _ASSERTE
 #define _ASSERTE(_expr) ASSERT(_expr)
 #endif
 #define CONSISTENCY_CHECK(_expr) ASSERT(_expr)
 #define COMPILER_ASSUME(cond) ASSERT(cond)
 #define EEPOLICY_HANDLE_FATAL_ERROR(error) ASSERT(!"EEPOLICY_HANDLE_FATAL_ERROR")
-#define UI64(_literal) _literal##ULL
 
 class ObjHeader;
 class MethodTable;

src/coreclr/gc/env/gcenv.interlocked.inl

@@ -1,6 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
-// __forceinline implementation of the Interlocked class methods
+// FORCEINLINE implementation of the Interlocked class methods
 //
 
 #ifndef __GCENV_INTERLOCKED_INL__
@@ -11,7 +11,7 @@
 #endif // _MSC_VER
 
 #ifndef _MSC_VER
-__forceinline void Interlocked::InterlockedOperationBarrier()
+FORCEINLINE void Interlocked::InterlockedOperationBarrier()
 {
 #if defined(HOST_ARM64) || defined(HOST_LOONGARCH64) || defined(HOST_RISCV64)
     // See PAL_InterlockedOperationBarrier() in the PAL
@@ -26,7 +26,7 @@ __forceinline void Interlocked::InterlockedOperationBarrier()
 // Return:
 //  The resulting incremented value
 template <typename T>
-__forceinline T Interlocked::Increment(T volatile *addend)
+FORCEINLINE T Interlocked::Increment(T volatile *addend)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -44,7 +44,7 @@ __forceinline T Interlocked::Increment(T volatile *addend)
 // Return:
 //  The resulting decremented value
 template <typename T>
-__forceinline T Interlocked::Decrement(T volatile *addend)
+FORCEINLINE T Interlocked::Decrement(T volatile *addend)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -63,7 +63,7 @@ __forceinline T Interlocked::Decrement(T volatile *addend)
 // Return:
 //  The previous value of the destination
 template <typename T>
-__forceinline T Interlocked::Exchange(T volatile *destination, T value)
+FORCEINLINE T Interlocked::Exchange(T volatile *destination, T value)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -84,7 +84,7 @@ __forceinline T Interlocked::Exchange(T volatile *destination, T value)
 // Return:
 //  The original value of the destination
 template <typename T>
-__forceinline T Interlocked::CompareExchange(T volatile *destination, T exchange, T comparand)
+FORCEINLINE T Interlocked::CompareExchange(T volatile *destination, T exchange, T comparand)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -103,7 +103,7 @@ __forceinline T Interlocked::CompareExchange(T volatile *destination, T exchange
 // Return:
 //  The previous value of the addend
 template <typename T>
-__forceinline T Interlocked::ExchangeAdd(T volatile *addend, T value)
+FORCEINLINE T Interlocked::ExchangeAdd(T volatile *addend, T value)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -116,7 +116,7 @@ __forceinline T Interlocked::ExchangeAdd(T volatile *addend, T value)
 }
 
 template <typename T>
-__forceinline T Interlocked::ExchangeAdd64(T volatile* addend, T value)
+FORCEINLINE T Interlocked::ExchangeAdd64(T volatile* addend, T value)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(int64_t) == sizeof(T), "Size of LONGLONG must be the same as size of T");
@@ -129,7 +129,7 @@ __forceinline T Interlocked::ExchangeAdd64(T volatile* addend, T value)
 }
 
 template <typename T>
-__forceinline T Interlocked::ExchangeAddPtr(T volatile* addend, T value)
+FORCEINLINE T Interlocked::ExchangeAddPtr(T volatile* addend, T value)
 {
 #ifdef _MSC_VER
 #ifdef HOST_64BIT
@@ -151,7 +151,7 @@ __forceinline T Interlocked::ExchangeAddPtr(T volatile* addend, T value)
 //  destination - the first operand and the destination
 //  value       - second operand
 template <typename T>
-__forceinline void Interlocked::And(T volatile *destination, T value)
+FORCEINLINE void Interlocked::And(T volatile *destination, T value)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -167,7 +167,7 @@ __forceinline void Interlocked::And(T volatile *destination, T value)
 //  destination - the first operand and the destination
 //  value       - second operand
 template <typename T>
-__forceinline void Interlocked::Or(T volatile *destination, T value)
+FORCEINLINE void Interlocked::Or(T volatile *destination, T value)
 {
 #ifdef _MSC_VER
     static_assert(sizeof(long) == sizeof(T), "Size of long must be the same as size of T");
@@ -185,7 +185,7 @@ __forceinline void Interlocked::Or(T volatile *destination, T value)
 // Return:
 //  The previous value of the destination
 template <typename T>
-__forceinline T Interlocked::ExchangePointer(T volatile * destination, T value)
+FORCEINLINE T Interlocked::ExchangePointer(T volatile * destination, T value)
 {
 #ifdef _MSC_VER
 #ifdef HOST_64BIT
@@ -201,7 +201,7 @@ __forceinline T Interlocked::ExchangePointer(T volatile * destination, T value)
 }
 
 template <typename T>
-__forceinline T Interlocked::ExchangePointer(T volatile * destination, std::nullptr_t value)
+FORCEINLINE T Interlocked::ExchangePointer(T volatile * destination, std::nullptr_t value)
 {
 #ifdef _MSC_VER
 #ifdef HOST_64BIT
@@ -225,7 +225,7 @@ __forceinline T Interlocked::ExchangePointer(T volatile * destination, std::null
 // Return:
 //  The original value of the destination
 template <typename T>
-__forceinline T Interlocked::CompareExchangePointer(T volatile *destination, T exchange, T comparand)
+FORCEINLINE T Interlocked::CompareExchangePointer(T volatile *destination, T exchange, T comparand)
 {
 #ifdef _MSC_VER
 #ifdef HOST_64BIT
@@ -241,7 +241,7 @@ __forceinline T Interlocked::CompareExchangePointer(T volatile *destination, T e
 }
 
 template <typename T>
-__forceinline T Interlocked::CompareExchangePointer(T volatile *destination, T exchange, std::nullptr_t comparand)
+FORCEINLINE T Interlocked::CompareExchangePointer(T volatile *destination, T exchange, std::nullptr_t comparand)
 {
 #ifdef _MSC_VER
 #ifdef HOST_64BIT

src/coreclr/gc/env/gcenv.unix.inl

@@ -11,7 +11,7 @@ extern uint32_t g_pageSizeUnixInl;
 #define OS_PAGE_SIZE GCToOSInterface::GetPageSize()
 
 #ifndef DACCESS_COMPILE
-__forceinline size_t GCToOSInterface::GetPageSize()
+FORCEINLINE size_t GCToOSInterface::GetPageSize()
 {
     return g_pageSizeUnixInl;
 }

src/coreclr/gc/env/gcenv.windows.inl

@@ -9,7 +9,7 @@
 
 #define OS_PAGE_SIZE GCToOSInterface::GetPageSize()
 
-__forceinline size_t GCToOSInterface::GetPageSize()
+FORCEINLINE size_t GCToOSInterface::GetPageSize()
 {
     return 0x1000;
 }

src/coreclr/gc/gc.cpp

@@ -5304,7 +5304,7 @@ struct initial_memory_details
             case 0: return block_size_normal;
             case 1: return block_size_large;
             case 2: return block_size_pinned;
-            default: __UNREACHABLE();
+            default: UNREACHABLE();
         }
     };
 
@@ -5317,7 +5317,7 @@ struct initial_memory_details
             case soh_gen2: return initial_normal_heap[h_number].memory_base;
             case loh_generation: return initial_large_heap[h_number].memory_base;
             case poh_generation: return initial_pinned_heap[h_number].memory_base;
-            default: __UNREACHABLE();
+            default: UNREACHABLE();
         }
     };
 
@@ -5330,7 +5330,7 @@ struct initial_memory_details
             case soh_gen2: return block_size_normal;
             case loh_generation: return block_size_large;
             case poh_generation: return block_size_pinned;
-            default: __UNREACHABLE();
+            default: UNREACHABLE();
         }
     };
 

src/coreclr/gc/gceventstatus.h

@@ -60,7 +60,7 @@ class GCEventStatus
      * IsEnabled queries whether or not the given level and keyword are
      * enabled on the given provider, returning true if they are.
      */
-    __forceinline static bool IsEnabled(GCEventProvider provider, GCEventKeyword keyword, GCEventLevel level)
+    FORCEINLINE static bool IsEnabled(GCEventProvider provider, GCEventKeyword keyword, GCEventLevel level)
     {
         assert(level >= GCEventLevel_None && level < GCEventLevel_Max);
 

src/coreclr/gc/handletablecore.cpp

@@ -685,7 +685,7 @@ void SegmentRemoveFreeBlocks(TableSegment *pSegment, uint32_t uType, BOOL *pfSca
 
 #ifdef HANDLE_OPTIMIZE_FOR_64_HANDLE_BLOCKS
         // determine whether this block is empty
-        if (((uint64_t*)pSegment->rgFreeMask)[uBlock] == UI64(0xFFFFFFFFFFFFFFFF))
+        if (((uint64_t*)pSegment->rgFreeMask)[uBlock] == 0xFFFFFFFFFFFFFFFFULL)
 #else
         // assume this block is empty until we know otherwise
         BOOL fEmpty = TRUE;
@@ -1039,7 +1039,7 @@ void SegmentResortChains(TableSegment *pSegment)
             {
 #ifdef HANDLE_OPTIMIZE_FOR_64_HANDLE_BLOCKS
                 // determine whether this block is empty
-                if (((uint64_t*)pSegment->rgFreeMask)[uBlock] == UI64(0xFFFFFFFFFFFFFFFF))
+                if (((uint64_t*)pSegment->rgFreeMask)[uBlock] == 0xFFFFFFFFFFFFFFFFULL)
 #else
                 // assume this block is empty until we know otherwise
                 BOOL fEmpty = TRUE;