define bool as Interop.BOOL to prevent upper bytes setting native bool (#92681)

github-actions[bot] · yowl · web-flow · commit 7027ff1a3090 · 2023-09-27T03:13:21.000-07:00
Co-authored-by: yowl &lt;scott.waye@hubse.com&gt;
diff --git a/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/InternalCalls.cs b/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/InternalCalls.cs
@@ -62,12 +62,12 @@ internal static class InternalCalls
         [RuntimeExport("RhCollect")]
         internal static void RhCollect(int generation, InternalGCCollectionMode mode, bool lowMemoryP = false)
         {
-            RhpCollect(generation, mode, lowMemoryP);
+            RhpCollect(generation, mode, lowMemoryP ? Interop.BOOL.TRUE : Interop.BOOL.FALSE);
         }
 
         [DllImport(Redhawk.BaseName)]
         [UnmanagedCallConv(CallConvs = new Type[] { typeof(CallConvCdecl) })]
-        private static extern void RhpCollect(int generation, InternalGCCollectionMode mode, bool lowMemoryP);
+        private static extern void RhpCollect(int generation, InternalGCCollectionMode mode, Interop.BOOL lowMemoryP);
 
         [RuntimeExport("RhGetGcTotalMemory")]
         internal static long RhGetGcTotalMemory()

Original file line number	Diff line number	Diff line change
`@@ -62,12 +62,12 @@ internal static class InternalCalls`
`62`	`62`	`[RuntimeExport("RhCollect")]`
`63`	`63`	`internal static void RhCollect(int generation, InternalGCCollectionMode mode, bool lowMemoryP = false)`
`64`	`64`	`{`
`65`		`- RhpCollect(generation, mode, lowMemoryP);`
	`65`	`+ RhpCollect(generation, mode, lowMemoryP ? Interop.BOOL.TRUE : Interop.BOOL.FALSE);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`[DllImport(Redhawk.BaseName)]`
`69`	`69`	`[UnmanagedCallConv(CallConvs = new Type[] { typeof(CallConvCdecl) })]`
`70`		`- private static extern void RhpCollect(int generation, InternalGCCollectionMode mode, bool lowMemoryP);`
	`70`	`+ private static extern void RhpCollect(int generation, InternalGCCollectionMode mode, Interop.BOOL lowMemoryP);`
`71`	`71`
`72`	`72`	`[RuntimeExport("RhGetGcTotalMemory")]`
`73`	`73`	`internal static long RhGetGcTotalMemory()`