Merge remote-tracking branch 'upstream/main' into github-sve2-api

Author: jacob-crawley

.github/copilot-instructions.md

@@ -1,8 +1,13 @@
-Important: **Ensure the code compiles and the tests pass.** Use the "Building & Testing in dotnet/runtime" instructions below.
+**Any code you commit SHOULD compile, and new and existing tests related to the change SHOULD pass.**
 
-Additionally,
+You MUST make your best effort to ensure your changes satisfy those criteria before committing. If for any reason you were unable to build or test the changes, you MUST report that. You MUST NOT claim success unless all builds and tests pass as described above.
+
+You MUST refer to the [Building & Testing in dotnet/runtime](#building--testing-in-dotnetruntime) instructions and use the commands and approaches specified there before attempting your own suggestions.
+
+You MUST follow all code-formatting and naming conventions defined in [`.editorconfig`](/.editorconfig).
+
+In addition to the rules enforced by `.editorconfig`, you SHOULD:
 
-- Follow all code-formatting and naming conventions defined in `./.editorconfig`.
 - Prefer file-scoped namespace declarations and single-line using directives.
 - Ensure that the final return statement of a method is on its own line.
 - Use pattern matching and switch expressions wherever possible.
@@ -17,6 +22,22 @@ Additionally,
 
 # Building & Testing in dotnet/runtime
 
+- [1. Prerequisites](#1-prerequisites)
+    - [1.1. Determine Affected Components](#11-determine-affected-components)
+    - [1.2. Baseline Setup](#12-baseline-setup)
+- [2. Iterative Build and Test Strategy](#2-iterative-build-and-test-strategy)
+    - [2.1. Success Criteria](#21-success-criteria)
+- [3. CoreCLR (CLR) Workflow](#3-coreclr-clr-workflow)
+- [4. Mono Runtime Workflow](#4-mono-runtime-workflow)
+- [5. Libraries Workflow](#5-libraries-workflow)
+    - [5.1. How To: Identify Affected Libraries](#51-how-to-identify-affected-libraries)
+    - [5.2. How To: Build and Test Specific Library](#52-how-to-build-and-test-specific-library)
+- [6. WebAssembly (WASM) Libraries Workflow](#6-webassembly-wasm-libraries-workflow)
+- [7. Additional Notes](#7-additional-notes)
+    - [7.1. Troubleshooting](#71-troubleshooting)
+    - [7.2. Windows Command Equivalents](#72-windows-command-equivalents)
+    - [7.3. References](#73-references)
+
 ## 1. Prerequisites
 
 These steps need to be done **before** applying any changes.
@@ -42,7 +63,7 @@ A change is considered WASM/WASI-relevant if:
 
 ### 1.2. Baseline Setup
 
-Ensure you have a full successful build of the needed runtime+libraries as a baseline.
+Before applying any changes, ensure you have a full successful build of the needed runtime+libraries as a baseline.
 
 1. Checkout `main` branch
 
@@ -53,7 +74,7 @@ Ensure you have a full successful build of the needed runtime+libraries as a bas
     - **WASM/WASI Libraries:** `./build.sh mono+libs -os browser`
 
 3. Verify the build completed without error.
-    - _If the build failed, report the failure and don't proceed with the changes._
+    - _If the baseline build failed, report the failure and don't proceed with the changes._
 
 4. From the repository root:
     - Configure PATH: `export PATH="$(pwd)/.dotnet:$PATH"`
@@ -106,14 +127,14 @@ When retrying, attempt different fixes and adjust based on the build/test result
 From the repository root:
 
 - Build:
-  `./build.sh -subset clr`
+  `./build.sh clr`
 
 - Run tests:
   `cd src/tests && ./build.sh && ./run.sh`
 
-- More info:
-    - [Building CoreCLR Guide](https://github.com/dotnet/runtime/blob/main/docs/workflow/building/coreclr/README.md)
-    - [Building and Running CoreCLR Tests](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/coreclr/testing.md)
+- More info can be found in the dedicated workflow docs:
+    - [Building CoreCLR Guide](/docs/workflow/building/coreclr/README.md)
+    - [Building and Running CoreCLR Tests](/docs/workflow/testing/coreclr/testing.md)
 
 ---
 
@@ -122,7 +143,7 @@ From the repository root:
 From the repository root:
 
 - Build:
-  `./build.sh -subset mono+libs`
+  `./build.sh mono+libs`
 
 - Run tests:
 
@@ -133,25 +154,31 @@ From the repository root:
   ./run.sh
   ```
 
-- More info:
-    - [Building Mono](https://github.com/dotnet/runtime/blob/main/docs/workflow/building/mono/README.md)
-    - [Running test suites using Mono](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/mono/testing.md)
+- More info can be found in the dedicated workflow docs:
+    - [Building Mono](/docs/workflow/building/mono/README.md)
+    - [Running test suites using Mono](/docs/workflow/testing/mono/testing.md)
 
 ---
 
 ## 5. Libraries Workflow
 
 From the repository root:
 
-- Build:
-  `./build.sh -subset libs -rc release`
+- Build all libraries:
+  `./build.sh libs -rc release`
 
-- Run tests:
-  `./build.sh -subset libs.tests -test -rc release`
+- Run all tests for libraries:
+  `./build.sh libs.tests -test -rc release`
 
-- More info:
-    - [Build Libraries](https://github.com/dotnet/runtime/blob/main/docs/workflow/building/libraries/README.md)
-    - [Testing Libraries](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing.md)
+- Build a specific library:
+    - Refer to the section [5.2. How To: Build and Test Specific Library](#52-how-to-build-and-test-specific-library) below.
+
+- Test a specific library:
+    - Refer to the sections [5.1. How To: Identify Affected Libraries](#51-how-to-identify-affected-libraries) and [5.2. How To: Build and Test Specific Library](#52-how-to-build-and-test-specific-library) below.
+
+- More info can be found in the dedicated workflow docs:
+    - [Build Libraries](/docs/workflow/building/libraries/README.md)
+    - [Testing Libraries](/docs/workflow/testing/libraries/testing.md)
 
 ### 5.1. How To: Identify Affected Libraries
 
@@ -202,9 +229,9 @@ From the repository root:
 - Run tests:
   `./build.sh libs.tests -test -os browser`
 
-- More info:
-    - [Build libraries for WebAssembly](https://github.com/dotnet/runtime/blob/main/docs/workflow/building/libraries/webassembly-instructions.md)
-    - [Testing Libraries on WebAssembly](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing-wasm.md)
+- More info can be found in the dedicated workflow docs:
+    - [Build libraries for WebAssembly](/docs/workflow/building/libraries/webassembly-instructions.md)
+    - [Testing Libraries on WebAssembly](/docs/workflow/testing/libraries/testing-wasm.md)
 
 ---
 
@@ -215,7 +242,7 @@ From the repository root:
 - **Shared Framework Missing**
 
     - If the build fails with an error "The shared framework must be built before the local targeting pack can be consumed.", build both the runtime (clr or mono) and the libs.
-      E.g., from the repo root, run `./build.sh clr+libs -rc release` if working on Libraries on CoreCLR. Refer to the section `1.2. Baseline Setup`.
+      E.g., from the repo root, run `./build.sh clr+libs -rc release` if working on Libraries on CoreCLR. To find the applicable command, refer to the section [1.2. Baseline Setup](#12-baseline-setup).
 
 - **Testhost Is Missing**
 
@@ -225,7 +252,7 @@ From the repository root:
       that means some of the prerequisites were not built.
 
     - To resolve, build both the appropriate runtime (clr or mono) and the libs as a single command before running tests.
-      E.g., from the repo root, run `./build.sh clr+libs -rc release` before testing Libraries on CoreCLR. Refer to the section `1.2. Baseline Setup`.
+      E.g., from the repo root, run `./build.sh clr+libs -rc release` before testing Libraries on CoreCLR. To find the applicable command, refer to the section [1.2. Baseline Setup](#12-baseline-setup).
 
 - **Build Timeout**
 
@@ -247,3 +274,17 @@ From the repository root:
 - Use `build.cmd` instead of `build.sh` on Windows.
 - Set PATH: `set PATH=%CD%\.dotnet;%PATH%`
 - All other commands are similar unless otherwise noted.
+
+---
+
+### 7.3. References
+
+- [`.editorconfig`](/.editorconfig)
+- [Building CoreCLR Guide](/docs/workflow/building/coreclr/README.md)
+- [Building and Running CoreCLR Tests](/docs/workflow/testing/coreclr/testing.md)
+- [Building Mono](/docs/workflow/building/mono/README.md)
+- [Running test suites using Mono](/docs/workflow/testing/mono/testing.md)
+- [Build Libraries](/docs/workflow/building/libraries/README.md)
+- [Testing Libraries](/docs/workflow/testing/libraries/testing.md)
+- [Build libraries for WebAssembly](/docs/workflow/building/libraries/webassembly-instructions.md)
+- [Testing Libraries on WebAssembly](/docs/workflow/testing/libraries/testing-wasm.md)

.github/workflows/copilot-setup-steps.yml

@@ -7,7 +7,7 @@ jobs:
   # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
   # See https://docs.github.com/en/copilot/customizing-copilot/customizing-the-development-environment-for-copilot-coding-agent
   copilot-setup-steps:
-    runs-on: ubuntu-latest
+    runs-on: 8-core-ubuntu-latest
 
     permissions:
       contents: read

Directory.Build.targets

@@ -26,7 +26,6 @@
   <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
   <Import Project="$(RepositoryEngineeringDir)toolAot.targets" />
   <Import Project="$(RepositoryEngineeringDir)generators.targets" />
-  <Import Project="$(RepositoryEngineeringDir)python.targets" />
   <Import Project="$(RepositoryEngineeringDir)generatorProjects.targets" Condition="'$(IsGeneratorProject)' == 'true'" />
   <Import Project="$(RepositoryEngineeringDir)resolveContract.targets" Condition="'$(IsSourceProject)' == 'true'" />
   <Import Project="$(RepositoryEngineeringDir)packaging.targets" Condition="'$(IsPackable)' == 'true' and '$(MSBuildProjectExtension)' != '.pkgproj'" />

docs/coding-guidelines/breaking-change-rules.md

@@ -238,6 +238,10 @@ successfully bind to that overload, if simply passing an `int` value. However, i
 
 * Adding a reference type field, a `ref` field, or a field involving a generic type parameter without the `unmanaged` constraint, to a value type that formerly had none of those field kinds. If the value type already contains at least one such field, adding another is non-breaking. This rule applies recursively to new fields that contain value types that may also introduce a new field kind.
 
+* Adding `partial` modifier to an interface method
+
+    Roslyn has [a spec violation](https://github.com/dotnet/roslyn/blob/6f6d64494dc75614f14ef1ac66dde3cc8d2d0092/docs/compilers/CSharp/Deviations%20from%20Standard.md#interface-partial-methods) that makes partial interface methods implicitly non-virtual. When you add the `partial` modifier to an interface method that was previously implicitly virtual, be sure to also include the `virtual` modifier to avoid a breaking change.
+
 ### Signatures
 ✓ **Allowed**
 * Adding `params` to a parameter

docs/tools/illink/data-formats.md

@@ -253,20 +253,6 @@ Entire method body is replaces with `throw` instruction when method is reference
 </linker>
 ```
 
-### Override static field value with a constant
-
-The `initialize` attribute is optional and when not specified the code to set the static field to the value will not be generated.
-
-```xml
-<linker>
-  <assembly fullname="Assembly">
-    <type fullname="Assembly.A">
-      <field name="MyNumericField" value="5" initialize="true" />
-    </type>
-  </assembly>
-</linker>
-```
-
 ### Remove embedded resources
 
 ```xml

eng/Version.Details.xml

@@ -41,7 +41,7 @@
       <Uri>https://github.com/dotnet/llvm-project</Uri>
       <Sha>da5dd054a531e6fea65643b7e754285b73eab433</Sha>
     </Dependency>
-    <Dependency Name="System.CommandLine" Version="2.0.0-beta5.25260.104">
+    <Dependency Name="System.CommandLine" Version="2.0.0-beta5.25279.2">
       <Uri>https://github.com/dotnet/dotnet</Uri>
       <Sha>85778473549347b3e4bad3ea009e9438df7b11bb</Sha>
     </Dependency>
@@ -263,7 +263,7 @@
       <Uri>https://github.com/dotnet/llvm-project</Uri>
       <Sha>da5dd054a531e6fea65643b7e754285b73eab433</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.5.25260.104">
+    <Dependency Name="Microsoft.NETCore.App.Ref" Version="10.0.0-preview.5.25260.104">
       <Uri>https://github.com/dotnet/dotnet</Uri>
       <Sha>85778473549347b3e4bad3ea009e9438df7b11bb</Sha>
     </Dependency>

eng/Versions.props

@@ -106,7 +106,7 @@
     <!-- NuGet dependencies -->
     <NuGetBuildTasksPackVersion>6.0.0-preview.1.102</NuGetBuildTasksPackVersion>
     <!-- Installer dependencies -->
-    <MicrosoftNETCoreAppRuntimewinx64Version>10.0.0-preview.5.25260.104</MicrosoftNETCoreAppRuntimewinx64Version>
+    <MicrosoftNETCoreAppRefVersion>10.0.0-preview.5.25260.104</MicrosoftNETCoreAppRefVersion>
     <MicrosoftExtensionsDependencyModelVersion>6.0.0</MicrosoftExtensionsDependencyModelVersion>
     <!-- ILAsm dependencies -->
     <MicrosoftNETCoreILAsmVersion>10.0.0-preview.5.25260.104</MicrosoftNETCoreILAsmVersion>
@@ -180,7 +180,7 @@
     <!-- Not auto-updated. -->
     <MicrosoftDiaSymReaderVersion>2.0.0</MicrosoftDiaSymReaderVersion>
     <MicrosoftDiaSymReaderNativeVersion>17.10.0-beta1.24272.1</MicrosoftDiaSymReaderNativeVersion>
-    <SystemCommandLineVersion>2.0.0-beta5.25260.104</SystemCommandLineVersion>
+    <SystemCommandLineVersion>2.0.0-beta5.25279.2</SystemCommandLineVersion>
     <TraceEventVersion>3.1.16</TraceEventVersion>
     <NETStandardLibraryRefVersion>2.1.0</NETStandardLibraryRefVersion>
     <NetStandardLibraryVersion>2.0.3</NetStandardLibraryVersion>

eng/pipelines/performance/templates/build-perf-sample-apps.yml

@@ -78,6 +78,29 @@ steps:
         workingDirectory: $(Build.SourcesDirectory)/artifacts/bin
         displayName: clean bindir
 
+      # CoreCLR JIT static linking build
+      - script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true
+        workingDirectory: $(Build.SourcesDirectory)/src/mono/sample/Android
+        displayName: Build HelloAndroid sample app RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true
+      - task: PublishBuildArtifacts@1
+        condition: succeededOrFailed()
+        displayName: 'Publish binlog'
+        inputs:
+          pathtoPublish: $(Build.SourcesDirectory)/src/mono/sample/Android/msbuild.binlog
+          artifactName:  AndroidCoreCLRArm64StaticLinkingBuildLog
+      - template: /eng/pipelines/common/upload-artifact-step.yml
+        parameters:
+          rootFolder: $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp/arm64/Release/android-arm64/Bundle/bin/HelloAndroid.apk
+          includeRootFolder: true
+          displayName: Android Sample App JIT CoreCLR Static Linking
+          artifactName: AndroidHelloWorldArm64CoreCLRStaticLinking
+          archiveExtension: '.tar.gz'
+          archiveType: tar
+          tarCompression: gz
+      - script: rm -r -f $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp
+        workingDirectory: $(Build.SourcesDirectory)/artifacts/bin
+        displayName: clean bindir
+
       # CoreCLR R2R build
       - script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR R2R=true
         workingDirectory: $(Build.SourcesDirectory)/src/mono/sample/Android

eng/pipelines/runtime.yml

@@ -531,7 +531,7 @@ extends:
           - name: timeoutPerTestCollectionInMinutes
             value: 180
           jobParameters:
-            timeoutInMinutes: 120
+            timeoutInMinutes: 180
             nameSuffix: NativeAOT
             buildArgs: -s clr.aot+libs -rc $(_BuildConfig) -lc Release /p:RunAnalyzers=false
             postBuildSteps:
@@ -614,7 +614,7 @@ extends:
             value: 180
           jobParameters:
             testGroup: innerloop
-            timeoutInMinutes: 120
+            timeoutInMinutes: 180
             nameSuffix: NativeAOT
             buildArgs: -s clr.aot+libs+tools.illink -c $(_BuildConfig) -rc $(_BuildConfig) -lc Release /p:RunAnalyzers=false
             postBuildSteps: