wip

Author: alefranz

src/libraries/Microsoft.Extensions.Configuration.Json/src/JsonConfigurationFileParser.cs

@@ -57,11 +57,6 @@ private void VisitElement(JsonElement element)
 
             if (isEmpty)
             {
-                //EnterContext("");
-                //_data[_currentPath] = "";
-                //ExitContext();
-
-                // when the object has no properties, we still want to have it as section
                 _data[_currentPath] = null;
             }
         }

src/libraries/Microsoft.Extensions.Configuration.Json/tests/IntegrationTest.cs

@@ -44,24 +44,6 @@ public void LoadJsonConfiguration()
                         x => AssertSection(x, "k", null),
                     }),
             });
-
-            //Assert.Collection(configuration.GetChildren(),
-            //    new Action<IConfigurationSection>[] {
-            //        x => AssertSection(x, "a", "b"),
-            //        x => AssertSection(x, "c", null, new Action<IConfigurationSection>[] {
-            //            x => AssertSection(x, "d", "e"),
-            //        }),
-            //        x => AssertSection(x, "f", ""),
-            //        x => AssertSection(x, "g", ""),
-            //        x => AssertSection(x, "h", null, new Action<IConfigurationSection>[] {
-            //            x => AssertSection(x, "", ""),
-            //        }),
-            //        x => AssertSection(x, "i", null, new Action<IConfigurationSection>[] {
-            //            x => AssertSection(x, "k", null, new Action<IConfigurationSection>[] {
-            //                x => AssertSection(x, "", ""),
-            //            }),
-            //        }),
-            //});
         }
 
         private static void AssertSection(IConfigurationSection configurationSection, string key, string value)

src/libraries/Microsoft.Extensions.Configuration/tests/ConfigurationTest.cs

@@ -791,7 +791,7 @@ public void KeyWithValueAndWithoutChildrenExistsAsSection(string value)
         }
 
         [Fact]
-        public void KeyWithNullValueAndWithoutChildrenIsNotASection()
+        public void KeyWithNullValueAndWithoutChildrenIsASectionButNotExists()
         {
             // Arrange
             var dict = new Dictionary<string, string>()
@@ -803,10 +803,14 @@ public void KeyWithNullValueAndWithoutChildrenIsNotASection()
             var config = configurationBuilder.Build();
 
             // Act
+            var sections = config.GetChildren();
             var sectionExists = config.GetSection("Mem1").Exists();
+            var sectionChildren = config.GetSection("Mem1").GetChildren();
 
             // Assert
+            Assert.Single(sections, section => section.Key == "Mem1");
             Assert.False(sectionExists);
+            Assert.Empty(sectionChildren);
         }
 
         [Fact]