Skip to content

Commit 342df93

Browse files
authored
[wasm] Move EnableAggressiveTrimming build to runtime pipeline (#52252)
.. from runtime-staging, so any changes that break that can be caught, and fixed. Any test failures in runtime-staging don't fail the job itself, so it gets missed.
1 parent 3476893 commit 342df93

File tree

2 files changed

+42
-38
lines changed

2 files changed

+42
-38
lines changed

eng/pipelines/runtime-staging.yml

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -227,44 +227,6 @@ jobs:
227227
eq(variables['monoContainsChange'], true),
228228
eq(variables['isFullMatrix'], true))
229229
230-
- template: /eng/pipelines/common/platform-matrix.yml
231-
parameters:
232-
jobTemplate: /eng/pipelines/common/global-build-job.yml
233-
helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
234-
buildConfig: Release
235-
runtimeFlavor: mono
236-
platforms:
237-
- Browser_wasm
238-
variables:
239-
# map dependencies variables to local variables
240-
- name: librariesContainsChange
241-
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ]
242-
- name: monoContainsChange
243-
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ]
244-
jobParameters:
245-
testGroup: innerloop
246-
nameSuffix: AllSubsets_Mono_EAT
247-
buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=false
248-
timeoutInMinutes: 180
249-
condition: >-
250-
or(
251-
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
252-
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
253-
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
254-
eq(variables['isFullMatrix'], true))
255-
# extra steps, run tests
256-
extraStepsTemplate: /eng/pipelines/libraries/helix.yml
257-
extraStepsParameters:
258-
creator: dotnet-bot
259-
testRunNamePrefixSuffix: Mono_$(_BuildConfig)
260-
extraHelixArguments: /p:NeedsToBuildWasmAppsOnHelix=true
261-
scenarios:
262-
- normal
263-
condition: >-
264-
or(
265-
eq(variables['librariesContainsChange'], true),
266-
eq(variables['monoContainsChange'], true),
267-
eq(variables['isFullMatrix'], true))
268230
269231
#
270232
# Build the whole product using Mono for Android and run runtime tests with Android emulator

eng/pipelines/runtime.yml

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,48 @@ jobs:
304304
eq(variables['monoContainsChange'], true),
305305
eq(variables['isFullMatrix'], true))
306306
307+
#
308+
# Build for Browser/wasm, with EnableAggressiveTrimming=true
309+
#
310+
- template: /eng/pipelines/common/platform-matrix.yml
311+
parameters:
312+
jobTemplate: /eng/pipelines/common/global-build-job.yml
313+
helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
314+
buildConfig: Release
315+
runtimeFlavor: mono
316+
platforms:
317+
- Browser_wasm
318+
variables:
319+
# map dependencies variables to local variables
320+
- name: librariesContainsChange
321+
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ]
322+
- name: monoContainsChange
323+
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ]
324+
jobParameters:
325+
testGroup: innerloop
326+
nameSuffix: AllSubsets_Mono_EAT
327+
buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=false
328+
timeoutInMinutes: 180
329+
condition: >-
330+
or(
331+
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
332+
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
333+
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
334+
eq(variables['isFullMatrix'], true))
335+
# extra steps, run tests
336+
extraStepsTemplate: /eng/pipelines/libraries/helix.yml
337+
extraStepsParameters:
338+
creator: dotnet-bot
339+
testRunNamePrefixSuffix: Mono_$(_BuildConfig)
340+
extraHelixArguments: /p:NeedsToBuildWasmAppsOnHelix=true
341+
scenarios:
342+
- normal
343+
condition: >-
344+
or(
345+
eq(variables['librariesContainsChange'], true),
346+
eq(variables['monoContainsChange'], true),
347+
eq(variables['isFullMatrix'], true))
348+
307349
# Build and test libraries under single-file publishing
308350
- template: /eng/pipelines/common/platform-matrix.yml
309351
parameters:

0 commit comments

Comments
 (0)