Skip to content

Commit 143bd05

Browse files
author
Mike McLaughlin
authored
Fix minidump generation - missing IP for exception stack frames (#115025)
This was caused by changes in PR #114582 where Exception::GetStackTrace called GetThread() which throws an error exception in the DAC. Changed the enummem.cpp code in ClrDataAccess::DumpManagedExcepObject() to call the GetStackTrace overload that allows a NULL pCurrentThread parameter to be passed.
1 parent 16260fb commit 143bd05

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/coreclr/debug/daccess/enummem.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ HRESULT ClrDataAccess::DumpManagedExcepObject(CLRDataEnumMemoryFlags flags, OBJE
561561
// included in the dump. When we touch the header and each element looking for the
562562
// MD this happens.
563563
StackTraceArray stackTrace;
564-
exceptRef->GetStackTrace(stackTrace);
564+
exceptRef->GetStackTrace(stackTrace, /*outKeepAliveArray*/ NULL, /* pCurrentThread */ NULL);
565565

566566
// The stackTraceArrayObj can be either a byte[] with the actual stack trace array or an object[] where the first element is the actual stack trace array.
567567
// In case it was the latter, we need to dump the actual stack trace array object here too.

0 commit comments

Comments
 (0)