diff --git a/eng/helixcorefxtests.proj b/eng/helixcorefxtests.proj
index b335ab42a4297..f25f1cc0e19e9 100644
--- a/eng/helixcorefxtests.proj
+++ b/eng/helixcorefxtests.proj
@@ -85,6 +85,7 @@
TODO: ProjectDir, RootBinDir, TestWorkingDir, and TargetsWindows are global properties set in dir.props, remove the property assignment here when we port to arcade.
-->
$(MSBuildThisFileDirectory)..\
+ $(ProjectDir)\src\coreclr\
$(ProjectDir)bin\
$(RootBinDir)tests\$(__BuildOS).$(__BuildArch).$(__BuildType)\
true
@@ -149,7 +150,7 @@
- <_ProjectsToBuild Include="..\tests\testenvironment.proj">
+ <_ProjectsToBuild Include="$(ProjectDir)tests\testenvironment.proj">
Scenario=$(Scenario);TestEnvFileName=$(TestEnvFilePath);TargetsWindows=$(TargetsWindows)
diff --git a/eng/pipelines/coreclr/templates/build-test-job.yml b/eng/pipelines/coreclr/templates/build-test-job.yml
index 880ee2935feb8..851673b48cd34 100644
--- a/eng/pipelines/coreclr/templates/build-test-job.yml
+++ b/eng/pipelines/coreclr/templates/build-test-job.yml
@@ -67,7 +67,7 @@ jobs:
displayName: Install native dependencies
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
# Necessary to install correct cmake version
- - script: $(coreClrRepoRootDir)eng\common\init-tools-native.cmd -InstallDirectory $(Build.SourcesDirectory)\native-tools -Force
+ - script: $(Build.SourcesDirectory)\eng\common\init-tools-native.cmd -InstallDirectory $(Build.SourcesDirectory)\native-tools -Force
displayName: Install native dependencies
diff --git a/eng/pipelines/coreclr/templates/crossgen-comparison-job.yml b/eng/pipelines/coreclr/templates/crossgen-comparison-job.yml
index b10490379eae5..a44820f01828e 100644
--- a/eng/pipelines/coreclr/templates/crossgen-comparison-job.yml
+++ b/eng/pipelines/coreclr/templates/crossgen-comparison-job.yml
@@ -40,14 +40,14 @@ jobs:
value: $(osGroup).$(hostArchType)_$(archType).$(buildConfigUpper)
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- name: binDirectory
- value: $(Build.SourcesDirectory)/bin
+ value: $(coreClrRepoRoot)/bin
- name: productDirectory
- value: $(Build.SourcesDirectory)/bin/Product
+ value: $(binDirectory)/Product
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
- name: binDirectory
- value: $(Build.SourcesDirectory)\bin
+ value: $(coreClrRepoRoot)\bin
- name: productDirectory
- value: $(Build.SourcesDirectory)\bin\Product
+ value: $(binDirectory\Product
# Test job depends on the corresponding build job
dependsOn: ${{ format('build_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
@@ -83,12 +83,8 @@ jobs:
# Populate Core_Root
- - ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- - script: ./build-test.sh $(buildConfig) $(archType) $(crossArg) generatelayoutonly
- displayName: Populate Core_Root
- - ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
- - script: build-test.cmd $(buildConfig) $(archType) generateLayoutOnly
- displayName: Populate Core_Root
+ - script: $(coreClrRepoRootDir)build-test$(scriptExt) $(buildConfig) $(archType) $(crossArg) generatelayoutonly
+ displayName: Populate Core_Root
# Create baseline output on the host (x64) machine
@@ -96,7 +92,7 @@ jobs:
displayName: Create cross-platform crossgen baseline
inputs:
scriptSource: 'filePath'
- scriptPath: $(Build.SourcesDirectory)/tests/scripts/crossgen_comparison.py
+ scriptPath: $(coreClrRepoRoot)/tests/scripts/crossgen_comparison.py
${{ if ne(parameters.osGroup, 'Windows_NT') }}:
arguments:
crossgen_framework
@@ -126,7 +122,7 @@ jobs:
Creator: $(Creator)
WorkItemTimeout: 1:00 # 1 hour
WorkItemDirectory: '$(binDirectory)'
- CorrelationPayloadDirectory: '$(Build.SourcesDirectory)/tests/scripts'
+ CorrelationPayloadDirectory: '$(coreClrRepoRoot)/tests/scripts'
${{ if ne(parameters.osName, 'Windows_NT') }}:
WorkItemCommand:
chmod +x $HELIX_WORKITEM_PAYLOAD/Product/$(targetFlavor)/crossgen;
diff --git a/eng/pipelines/coreclr/templates/perf-job.yml b/eng/pipelines/coreclr/templates/perf-job.yml
index f0d598d718049..a6b0998105778 100644
--- a/eng/pipelines/coreclr/templates/perf-job.yml
+++ b/eng/pipelines/coreclr/templates/perf-job.yml
@@ -55,9 +55,9 @@ jobs:
# Create Core_Root
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- - script: ./build-test.sh ${{ parameters.buildConfig }} ${{ parameters.archType }} generatelayoutonly
+ - script: $(coreClrRepoRootDir)build-test$(scriptExt) ${{ parameters.buildConfig }} ${{ parameters.archType }} generatelayoutonly
displayName: Create Core_Root
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
# TODO: add generatelayoutonly to build-test.cmd.
- - script: build-test.cmd ${{ parameters.buildConfig }} ${{ parameters.archType }} skipmanaged skipnative
+ - script: $(coreClrRepoRootDir)build-test$(scriptExt) ${{ parameters.buildConfig }} ${{ parameters.archType }} skipmanaged skipnative
displayName: Create Core_Root
\ No newline at end of file
diff --git a/eng/pipelines/coreclr/templates/run-test-job.yml b/eng/pipelines/coreclr/templates/run-test-job.yml
index ddac9b17b6181..3b26e220a8a58 100644
--- a/eng/pipelines/coreclr/templates/run-test-job.yml
+++ b/eng/pipelines/coreclr/templates/run-test-job.yml
@@ -250,7 +250,7 @@ jobs:
# Choose which tests to send to Helix: CoreFX or CoreCLR.
${{ if eq(parameters.corefxTests, true) }}:
- helixProjectArguments: '$(coreClrRepoRoot)/eng/helixcorefxtests.proj'
+ helixProjectArguments: '$(Build.SourcesDirectory)/eng/helixcorefxtests.proj'
${{ if ne(parameters.corefxTests, true) }}:
helixProjectArguments: '$(coreClrRepoRoot)/tests/src/helixpublishwitharcade.proj'
diff --git a/eng/pipelines/coreclr/templates/xplat-pipeline-job.yml b/eng/pipelines/coreclr/templates/xplat-pipeline-job.yml
index ffc806edf8714..ac96e979781ae 100644
--- a/eng/pipelines/coreclr/templates/xplat-pipeline-job.yml
+++ b/eng/pipelines/coreclr/templates/xplat-pipeline-job.yml
@@ -80,9 +80,9 @@ jobs:
value: '/'
- name: coreClrRepoRoot
- value: '$(Build.SourcesDirectory)/src/coreclr
+ value: '$(Build.SourcesDirectory)/src/coreclr'
- - ${{ if not(startsWith(variables['Build.DefinitionName'], 'runtime')) }}:'
+ - ${{ if not(startsWith(variables['Build.DefinitionName'], 'runtime')) }}:
- name: coreClrRepoRoot
value: '$(Build.SourcesDirectory)'
diff --git a/src/coreclr/build-test.cmd b/src/coreclr/build-test.cmd
index 870f7e66c30ea..8094f59a86392 100644
--- a/src/coreclr/build-test.cmd
+++ b/src/coreclr/build-test.cmd
@@ -276,7 +276,7 @@ if "%__SkipRestorePackages%" == "1" goto SkipRestoreProduct
echo %__MsgPrefix%Restoring CoreCLR product from packages
if not defined XunitTestBinBase set XunitTestBinBase=%__TestBinDir%
-set "CORE_ROOT=%XunitTestBinBase%\Tests\Core_Root"
+set "CORE_ROOT=%XunitTestBinBase%\Tests\Core_Root\"
set __BuildLogRootName=Restore_Product
set __BuildLog=%__LogsDir%\%__BuildLogRootName%_%__BuildOS%__%__BuildArch%__%__BuildType%.log
diff --git a/src/coreclr/build.sh b/src/coreclr/build.sh
index d2d3dad1f5ee4..9eb5824525edc 100755
--- a/src/coreclr/build.sh
+++ b/src/coreclr/build.sh
@@ -235,7 +235,7 @@ build_native()
__versionSourceFile="$intermediatesForBuild/version.c"
if [ $__SkipGenerateVersion == 0 ]; then
pwd
- "$__RepoRootDir/eng/common/msbuild.sh" $__ArcadeScriptArgs $__ProjectRoot/eng/empty.csproj \
+ "$__RepoRootDir/eng/common/msbuild.sh" $__ArcadeScriptArgs $__RepoRootDir/eng/empty.csproj \
/p:NativeVersionFile=$__versionSourceFile \
/t:GenerateNativeVersionFile /restore \
$__CommonMSBuildArgs $__UnprocessedBuildArgs
diff --git a/src/coreclr/tests/runtest.cmd b/src/coreclr/tests/runtest.cmd
index f2c550d344b11..65a48c6b506b2 100644
--- a/src/coreclr/tests/runtest.cmd
+++ b/src/coreclr/tests/runtest.cmd
@@ -118,7 +118,7 @@ set "__TestWorkingDir=%__RootBinDir%\tests\%__BuildOS%.%__BuildArch%.%__BuildTyp
:: Default global test environment variables
:: REVIEW: are these ever expected to be defined on entry to this script? Why? By whom?
:: REVIEW: XunitTestReportDirBase is not used in this script. Who needs to have it set?
-if not defined XunitTestBinBase set XunitTestBinBase=%__TestWorkingDir%
+if not defined XunitTestBinBase set XunitTestBinBase=%__TestWorkingDir%\
if not defined XunitTestReportDirBase set XunitTestReportDirBase=%XunitTestBinBase%\Reports\
REM At this point in the script there will be a divergence in how the tests are run.
diff --git a/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByOut/CMakeLists.txt b/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByOut/CMakeLists.txt
index f9639aa95aa7d..151d42f06c3d2 100644
--- a/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByOut/CMakeLists.txt
+++ b/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByOut/CMakeLists.txt
@@ -1,5 +1,5 @@
cmake_minimum_required (VERSION 2.6)
-project (ReversePInvokePassingByOutNative)
+project (RPIP_ByOutNative)
include ("${CLR_INTEROP_TEST_ROOT}/Interop.cmake")
include_directories("..")
set(SOURCES
@@ -7,7 +7,8 @@ set(SOURCES
)
# Additional files to reference:
# add the executable
-add_library (ReversePInvokePassingByOutNative SHARED ${SOURCES})
-target_link_libraries(ReversePInvokePassingByOutNative ${LINK_LIBRARIES_ADDITIONAL})
+add_library (RPIP_ByOutNative SHARED ${SOURCES})
+set_property (TARGET RPIP_ByOutNative PROPERTY OUTPUT_NAME ReversePInvokePassingByOutNative)
+target_link_libraries(RPIP_ByOutNative ${LINK_LIBRARIES_ADDITIONAL})
# add the install targets
-install (TARGETS ReversePInvokePassingByOutNative DESTINATION bin)
+install (TARGETS RPIP_ByOutNative DESTINATION bin)
diff --git a/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByRef/CMakeLists.txt b/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByRef/CMakeLists.txt
index 180d43c9676c7..3176cfc826e96 100644
--- a/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByRef/CMakeLists.txt
+++ b/src/coreclr/tests/src/Interop/PInvoke/SizeParamIndex/ReversePInvoke/PassingByRef/CMakeLists.txt
@@ -1,5 +1,5 @@
cmake_minimum_required (VERSION 2.6)
-project (ReversePInvokePassingByRefNative)
+project (RPIP_ByRefNative)
include ("${CLR_INTEROP_TEST_ROOT}/Interop.cmake")
include_directories("..")
set(SOURCES
@@ -7,7 +7,8 @@ set(SOURCES
)
# Additional files to reference:
# add the executable
-add_library (ReversePInvokePassingByRefNative SHARED ${SOURCES})
-target_link_libraries(ReversePInvokePassingByRefNative ${LINK_LIBRARIES_ADDITIONAL})
+add_library (RPIP_ByRefNative SHARED ${SOURCES})
+set_property (TARGET RPIP_ByRefNative PROPERTY OUTPUT_NAME ReversePInvokePassingByRefNative)
+target_link_libraries(RPIP_ByRefNative ${LINK_LIBRARIES_ADDITIONAL})
# add the install targets
-install (TARGETS ReversePInvokePassingByRefNative DESTINATION bin)
+install (TARGETS RPIP_ByRefNative DESTINATION bin)