From b139ee82b64fc9c810c601213c0846dae6899ea0 Mon Sep 17 00:00:00 2001 From: Josef Pihrt Date: Sun, 31 Aug 2025 12:30:39 +0200 Subject: [PATCH 1/2] fix --- ...FormatDocumentationCommentSummaryAnalyzer.cs | 14 ++++++++++++++ ...253FormatDocumentationCommentSummaryTests.cs | 17 +++++++++++++++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/src/Analyzers/CSharp/Analysis/FormatDocumentationCommentSummaryAnalyzer.cs b/src/Analyzers/CSharp/Analysis/FormatDocumentationCommentSummaryAnalyzer.cs index ce95502de7..ffe13e7313 100644 --- a/src/Analyzers/CSharp/Analysis/FormatDocumentationCommentSummaryAnalyzer.cs +++ b/src/Analyzers/CSharp/Analysis/FormatDocumentationCommentSummaryAnalyzer.cs @@ -92,6 +92,20 @@ private static void AnalyzeSingleLineDocumentationCommentTrivia(SyntaxNodeAnalys if (endTag?.IsMissing == false && startTag.GetSpanEndLine() < endTag.GetSpanStartLine()) { + foreach (XmlNodeSyntax node in summaryElement.Content) + { + if (node is XmlElementSyntax xmlElement) + { + switch (xmlElement.GetTag()) + { + case XmlTag.Code: + case XmlTag.List: + case XmlTag.Para: + return; + } + } + } + Match match = SingleLineSummaryRegex.Match( summaryElement.ToString(), startTag.Span.End - summaryElement.SpanStart, diff --git a/src/Tests/Analyzers.Tests/RCS1253FormatDocumentationCommentSummaryTests.cs b/src/Tests/Analyzers.Tests/RCS1253FormatDocumentationCommentSummaryTests.cs index fc31e20b1e..1a6cd86b43 100644 --- a/src/Tests/Analyzers.Tests/RCS1253FormatDocumentationCommentSummaryTests.cs +++ b/src/Tests/Analyzers.Tests/RCS1253FormatDocumentationCommentSummaryTests.cs @@ -77,13 +77,13 @@ public async Task Test_ToSingleLine() { await VerifyDiagnosticAndFixAsync(@" /// [| -/// abc +/// abc /// |] class C { } ", @" -/// abc +/// abc class C { } @@ -179,6 +179,19 @@ await VerifyNoDiagnosticAsync(@" class C { } +", options: Options.AddConfigOption(ConfigOptionKeys.DocCommentSummaryStyle, ConfigOptionValues.DocCommentSummaryStyle_SingleLine)); + } + + [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.FormatDocumentationCommentSummary)] + public async Task TestNoDiagnostic_ParaElement_ToSingleLine() + { + await VerifyNoDiagnosticAsync(@" +/// +/// x +/// +class C +{ +} ", options: Options.AddConfigOption(ConfigOptionKeys.DocCommentSummaryStyle, ConfigOptionValues.DocCommentSummaryStyle_SingleLine)); } } From 07540d0716929d87e32d70c160221d04b00e8a6e Mon Sep 17 00:00:00 2001 From: Josef Pihrt Date: Sun, 31 Aug 2025 12:33:36 +0200 Subject: [PATCH 2/2] changelog --- ChangeLog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog.md b/ChangeLog.md index 3213038c68..96e79378b7 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix analyzer [RCS1043](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1043) ([PR](https://github.com/dotnet/roslynator/pull/1684)) - Fix analyzer [RCS1213](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1213) ([PR](https://github.com/dotnet/roslynator/pull/1686)) - Add unity method `OnRectTransformDimensionsChange` +- Fix analyzer [RCS1253](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1253) ([PR](https://github.com/dotnet/roslynator/pull/1687)) - Fix refactoring [Check expression for null](https://josefpihrt.github.io/docs/roslynator/refactorings/RR0024) ([PR](https://github.com/dotnet/roslynator/pull/1682)) ## [4.14.0] - 2025-07-26