Skip to content

Fix IDE0032: Code fixer adds setter for static properties with instance constructor writes #81327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 6 commits into from
Nov 19, 2025
Merged

Fix IDE0032: Code fixer adds setter for static properties with instance constructor writes #81327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2860468
Initial plan
Copilot Nov 19, 2025
4efc5ba
Fix IDE0032 analyzer to prevent invalid code for static fields in ins…
Copilot Nov 19, 2025
dafbf3f
Fix IDE0032 code fixer to add setter for static properties with insta…
Copilot Nov 19, 2025
a45616a
Update src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTest…
CyrusNajmabadi Nov 19, 2025
656dd5f
Fixup
CyrusNajmabadi Nov 19, 2025
2e46dba
Fixup
CyrusNajmabadi Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3214,4 +3214,93 @@ class C
public string Goo { get => field ?? throw new System.InvalidOperationException(); } = "";
}
""" + s_allowNullAttribute);

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/81320")]
public Task TestStaticFieldWrittenInInstanceConstructor_ReadOnlyProperty()
=> TestInRegularAndScriptAsync(
"""
public sealed class Test
{
[|private static Test? s_instance;|]
public static Test Instance => s_instance!;

public Test()
{
s_instance = this;
}
}
""",
"""
public sealed class Test
{
public static Test Instance { get => field!; private set; }

public Test()
{
Instance = this;
}
}
""");

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/XXXXX")]
public Task TestStaticFieldWrittenInStaticConstructor_ReadOnlyProperty()
=> TestInRegularAndScriptAsync(
"""
public sealed class Test
{
[|private static Test? s_instance;|]
public static Test Instance => s_instance!;

static Test()
{
s_instance = new Test();
}
}
""",
"""
public sealed class Test
{
public static Test Instance => field!;

static Test()
{
Instance = new Test();
}
}
""");

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/XXXXX")]
public Task TestStaticFieldWrittenInInstanceConstructor_WithSetter()
=> TestInRegularAndScriptAsync(
"""
public sealed class Test
{
[|private static Test? s_instance;|]
public static Test Instance
{
get => s_instance!;
set => s_instance = value;
}

public Test()
{
s_instance = this;
}
}
""",
"""
public sealed class Test
{
public static Test Instance
{
get => field!;
set;
}

public Test()
{
Instance = this;
}
}
""");
}
5 changes: 4 additions & 1 deletion src/Analyzers/Core/CodeFixes/UseAutoProperty/AbstractUseAutoPropertyCodeFixProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,9 +484,12 @@ private async Task<SyntaxNode> FormatAsync(
CancellationToken cancellationToken)
{
var isWrittenOutsideConstructor = false;

// Only include constructors that match the static-ness of the field. For a static field, only static
// constructors are relevant. For an instance field, only instance constructors are relevant.
var constructorSpans = field.ContainingType
.GetMembers()
.Where(m => m.IsConstructor())
.Where(m => field.IsStatic ? m.IsStaticConstructor() : m.IsConstructor())
.SelectMany(c => c.DeclaringSyntaxReferences)
.Select(s => s.GetSyntax(cancellationToken))
.Select(n => n.FirstAncestorOrSelf<TConstructorDeclaration>())
Expand Down
Loading