From bb8666ee6e38bdf9f35b8a9f2e9e5c8140aaa2c8 Mon Sep 17 00:00:00 2001 From: Julien Couvreur Date: Tue, 12 Aug 2025 09:44:56 -0700 Subject: [PATCH 1/2] Update checklist for adding new language version --- src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs index de1e8bee48d18..7e50525deca62 100644 --- a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs +++ b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs @@ -1722,6 +1722,7 @@ public void LanguageVersionAdded_Canary() // - [ ] replace all references to C# "Next" (such as `TestOptions.RegularNext` or `LanguageVersionFacts.CSharpNext`) with the new version and fix failing tests // - [ ] update _MaxAvailableLangVersion cap (a relevant test should break when new version is introduced) // - [ ] update the "UpgradeProject" codefixer + // - [ ] test VS insertion and deal with breaking changes // // Other repos also need updates: // - [ ] email release management to add to the release notes. See csharp-version in release.json in previous example: https://github.com/dotnet/core/pull/9493 From 7d33651f1b8444ad6bdb721adc6c48de856fa6b7 Mon Sep 17 00:00:00 2001 From: Julien Couvreur Date: Tue, 12 Aug 2025 09:59:03 -0700 Subject: [PATCH 2/2] Update CommandLineTests.cs --- src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs index 7e50525deca62..0b5da55168742 100644 --- a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs +++ b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs @@ -1722,7 +1722,7 @@ public void LanguageVersionAdded_Canary() // - [ ] replace all references to C# "Next" (such as `TestOptions.RegularNext` or `LanguageVersionFacts.CSharpNext`) with the new version and fix failing tests // - [ ] update _MaxAvailableLangVersion cap (a relevant test should break when new version is introduced) // - [ ] update the "UpgradeProject" codefixer - // - [ ] test VS insertion and deal with breaking changes + // - [ ] test VS insertion and deal with breaking changes. (note: the runtime repo uses "preview" so breaks are resolved sooner) // // Other repos also need updates: // - [ ] email release management to add to the release notes. See csharp-version in release.json in previous example: https://github.com/dotnet/core/pull/9493