From e85d47f754ea1814dc34131da80b88690343144c Mon Sep 17 00:00:00 2001 From: David Barbet Date: Tue, 22 Jul 2025 12:10:45 -0700 Subject: [PATCH] Fix auth issue in PR val builds --- azure-pipelines-pr-validation.yml | 41 ++++++++++++++----------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/azure-pipelines-pr-validation.yml b/azure-pipelines-pr-validation.yml index 12b91f1423406..0afa702c1f38e 100644 --- a/azure-pipelines-pr-validation.yml +++ b/azure-pipelines-pr-validation.yml @@ -165,28 +165,6 @@ extends: displayName: Setting SourceBranchName variable condition: succeeded() - - task: Powershell@2 - name: FancyBuild - displayName: Setting FancyBuild.BuildNumber - inputs: - targetType: inline - script: | - $pull_request = Invoke-RestMethod -Uri "https://api.github.com/repos/dotnet/roslyn/pulls/${{ parameters.PRNumber }}" ` - -Headers @{ - "Accept" = "application/vnd.github+json"; - "X-GitHub-Api-Version" = "2022-11-28" - } - $buildNumberName = "$(OriginalBuildNumber) - $($pull_request.user.login) - '$($pull_request.title)'" - $buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_' - # Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space. - if ($buildNumberName.Length -GT 253) { - $buildNumberName = $buildNumberName.Substring(0, 253) - } - # Avoid ever ending the BuildNumber with a `.` by always appending to it. - $buildNumberName += ' #' - Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName" - Write-Host "##vso[build.updatebuildnumber]$buildNumberName" - - task: Powershell@2 displayName: Tag PR validation build inputs: @@ -204,6 +182,25 @@ extends: arguments: "-sourceBranchName $(SourceBranchName) -prNumber ${{ parameters.PRNumber }} -commitSHA ${{ parameters.CommitSHA }} -enforceLatestCommit ${{ iif(parameters.EnforceLatestCommit, '1', '0') }}" condition: succeeded() + - task: Powershell@2 + name: FancyBuild + displayName: Setting FancyBuild.BuildNumber + inputs: + targetType: inline + script: | + $authorName = git log -1 --pretty=format:"%an" ${{ parameters.CommitSHA }} + + $buildNumberName = "$(OriginalBuildNumber) - $($authorName) - '${{ parameters.PRNumber }}'" + $buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_' + # Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space. + if ($buildNumberName.Length -GT 253) { + $buildNumberName = $buildNumberName.Substring(0, 253) + } + # Avoid ever ending the BuildNumber with a `.` by always appending to it. + $buildNumberName += ' #' + Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName" + Write-Host "##vso[build.updatebuildnumber]$buildNumberName" + - powershell: Write-Host "##vso[task.setvariable variable=VisualStudio.DropName]Products/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(OriginalBuildNumber)" displayName: Setting VisualStudio.DropName variable