Skip to content

Move Range and Index to Contracts source package #78371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 1 commit into from
Apr 29, 2025
Merged

Move Range and Index to Contracts source package #78371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .../Core/Portable/InternalUtilities/Index.cs → src/Dependencies/Contracts/Index.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#if !NETCOREAPP
#if NET

#pragma warning disable RS0016 // Add public types and members to the declared API (this is a supporting forwarder for an internal polyfill API)
[assembly: System.Runtime.CompilerServices.TypeForwardedTo(typeof(System.Index))]
#pragma warning restore RS0016 // Add public types and members to the declared API

#else

using System.Runtime.CompilerServices;

namespace System
{
/// <summary>Represent a type can be used to index a collection either from the start or the end.</summary>
Expand Down
2 changes: 2 additions & 0 deletions src/Dependencies/Contracts/Microsoft.CodeAnalysis.Contracts.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
<Compile Include="$(MSBuildThisFileDirectory)RequiredMemberAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)SetsRequiredMembersAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)ExceptionUtilities.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Index.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Range.cs" />
</ItemGroup>
<ItemGroup Condition="'$(DefaultLanguageSourceExtension)' != '' AND '$(BuildingInsideVisualStudio)' != 'true'">
<ExpectedCompile Include="$(MSBuildThisFileDirectory)**\*$(DefaultLanguageSourceExtension)" />
Expand Down
14 changes: 9 additions & 5 deletions .../Core/Portable/InternalUtilities/Range.cs → src/Dependencies/Contracts/Range.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#if !NETCOREAPP
#if NET

#pragma warning disable RS0016 // Add public types and members to the declared API (this is a supporting forwarder for an internal polyfill API)
[assembly: System.Runtime.CompilerServices.TypeForwardedTo(typeof(System.Range))]
#pragma warning restore RS0016 // Add public types and members to the declared API

#else
using System.Runtime.CompilerServices;
using Roslyn.Utilities;

namespace System
{
/// <summary>Represent a range has start and end indexes.</summary>
Expand Down Expand Up @@ -46,9 +52,7 @@ value is Range r &&

/// <summary>Returns the hash code for this instance.</summary>
public override int GetHashCode()
{
return Hash.Combine(Start.GetHashCode(), End.GetHashCode());
}
=> unchecked(Start.GetHashCode() * (int)0xA5555529 + End.GetHashCode());

/// <summary>Converts the value of the current Range object to its equivalent string representation.</summary>
public override string ToString()
Expand Down
5 changes: 0 additions & 5 deletions src/Tools/SemanticSearch/BuildTask/SemanticSearch.BuildTask.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,5 @@
<ItemGroup>
<InternalsVisibleTo Include="SemanticSearch.BuildTask.UnitTests" />
</ItemGroup>
<ItemGroup>
<Compile Include="..\..\..\Compilers\Core\Portable\InternalUtilities\Range.cs" Link="Utilities\Range.cs" />
<Compile Include="..\..\..\Compilers\Core\Portable\InternalUtilities\Index.cs" Link="Utilities\Index.cs" />
<Compile Include="..\..\..\Compilers\Core\Portable\InternalUtilities\Hash.cs" Link="Utilities\Hash.cs" />
</ItemGroup>
<Import Project="..\..\..\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems" Label="Shared" />
</Project>
6 changes: 0 additions & 6 deletions src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\ImmutableListExtensions.cs">
<Link>InternalUtilities\ImmutableListExtensions.cs</Link>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\Index.cs">
<Link>InternalUtilities\Index.cs</Link>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\ISetExtensions.cs">
<Link>InternalUtilities\ISetExtensions.cs</Link>
</Compile>
Expand All @@ -140,9 +137,6 @@
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\PlatformInformation.cs">
<Link>InternalUtilities\PlatformInformation.cs</Link>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\Range.cs">
<Link>InternalUtilities\Range.cs</Link>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)..\..\..\..\Compilers\Core\Portable\InternalUtilities\ReaderWriterLockSlimExtensions.cs">
<Link>InternalUtilities\ReaderWriterLockSlimExtensions.cs</Link>
</Compile>
Expand Down