Skip to content

Use collection expressions #78237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

Use collection expressions #78237

merged 4 commits into from
Apr 22, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 21, 2025

No description provided.

@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 21, 2025
@CyrusNajmabadi CyrusNajmabadi force-pushed the useCollectionExpr branch 11 times, most recently from 2d3b273 to 5e3c33d Compare April 21, 2025 22:31
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 22, 2025 17:31
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 22, 2025 17:31
ToddGrun
ToddGrun reviewed Apr 22, 2025
View reviewed changes
src/ExpressionEvaluator/Core/Source/ExpressionCompiler/EEMetadataReferenceResolver.cs Outdated
#if DEBUG
internal readonly Dictionary<AssemblyIdentity, (AssemblyIdentity? Identity, int Count)> Requests =
new Dictionary<AssemblyIdentity, (AssemblyIdentity? Identity, int Count)>();
[];
Copy link
Contributor

@ToddGrun ToddGrun Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        [](http://example.com/codeflow?start=0&length=12)

nit: remove newline

ToddGrun
ToddGrun reviewed Apr 22, 2025
View reviewed changes
src/Features/Core/Portable/Workspace/CompileTimeSolutionProvider.cs Outdated
/// </summary>
#if NET
private readonly ConditionalWeakTable<Solution, Solution> _designTimeToCompileTimeSolution = [];
private readonly ConditionalWeakTable<Solution, Solution> _designTimeToCompileTimeSolution = new();
Copy link
Contributor

@ToddGrun ToddGrun Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new();

why did this one go the other way?

ToddGrun
ToddGrun approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 4768d19 into dotnet:main Apr 22, 2025
24 of 25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the useCollectionExpr branch April 22, 2025 19:26
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 22, 2025
This was referenced Apr 24, 2025
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

4 participants

@CyrusNajmabadi @DustinCampbell @ToddGrun @RikkiGibson