Skip to content

Revert "Handle textDocument/didChange notifications that don't pass a… #78227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

Revert "Handle textDocument/didChange notifications that don't pass a… #78227

merged 1 commit into from
Apr 20, 2025

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Apr 20, 2025 •
edited
Loading

…cross the range (#78165)"

This reverts commit 59eae07, reversing changes made to 20e9836.

Breaks Razor

04/19/2025 07:45:59.186 [9876]: 2>Warning: System.MissingMethodException: Method not found: 'Roslyn.LanguageServer.Protocol.TextDocumentContentChangeEvent[] Roslyn.LanguageServer.Protocol.DidChangeTextDocumentParams.get_ContentChanges()'. while resolving 0xa0007f6 - Roslyn.LanguageServer.Protocol.DidChangeTextDocumentParams.get_ContentChanges.
04/19/2025 07:45:59.608 [9876]: 2>Method not found: 'Roslyn.LanguageServer.Protocol.TextDocumentContentChangeEvent[] Roslyn.LanguageServer.Protocol.DidChangeTextDocumentParams.get_ContentChanges()'. while compiling method <HandleNotificationAsync>d__7.MoveNext

@dibarbet
Revert "Handle textDocument/didChange notifications that don't pass a…
868038d 
…cross the range (dotnet#78165)"

This reverts commit 59eae07, reversing
changes made to 20e9836.
@dibarbet dibarbet requested a review from a team as a code owner April 20, 2025 19:29
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2025
@dibarbet dibarbet merged commit 0242548 into dotnet:main Apr 20, 2025
25 checks passed
@dibarbet dibarbet deleted the revert_didChange branch April 20, 2025 20:58
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 20, 2025
This was referenced Apr 21, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

2 participants

@dibarbet @RikkiGibson