Skip to content

Remove unused elements form PublishData.json #77994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredpar merged 1 commit into from
Apr 3, 2025
Merged

Remove unused elements form PublishData.json #77994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions eng/config/PublishData.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,16 +120,14 @@
},
"dev15.9.x-vs-deps": {
"nugetKind": "PerBuildPreRelease",
"vsBranch": "rel/d15.9",
"vsMajorVersion": 15
Copy link
Member

@RikkiGibson RikkiGibson Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our official builds always read this file from the main branch, do we need to do some manual testing to be sure this won't break servicing branch builds? We have a monthly smoke test that we are supposed to keep an eye on, FWIW.

Copy link
Member Author

@jaredpar jaredpar Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put my local enlistment into a time machine and we don't even use vsMajorVersion in our 15.9 code

Copy link
Member Author

@jaredpar jaredpar Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case rel/d15.9 isn't even a real branch, we use dev15.9.x so think this entire section is suspect.

"vsBranch": "rel/d15.9"
},
"release/dev16.11-vs-deps": {
"nugetKind": [
"Shipping",
"NonShipping"
],
"vsBranch": "rel/d16.11",
"vsMajorVersion": 16,
"insertionTitlePrefix": "[d16.11]"
},
"release/dev17.8": {
Expand All @@ -138,7 +136,6 @@
"NonShipping"
],
"vsBranch": "rel/d17.8",
"vsMajorVersion": 17,
"insertionTitlePrefix": "[d17.8]"
},
"release/dev17.10": {
Expand All @@ -147,7 +144,6 @@
"NonShipping"
],
"vsBranch": "rel/d17.10",
"vsMajorVersion": 17,
"insertionTitlePrefix": "[d17.10]"
},
"release/dev17.12": {
Expand All @@ -156,7 +152,6 @@
"NonShipping"
],
"vsBranch": "rel/d17.12",
"vsMajorVersion": 17,
"insertionTitlePrefix": "[d17.12]"
},
"release/dev17.13": {
Expand All @@ -165,7 +160,6 @@
"NonShipping"
],
"vsBranch": "rel/d17.13",
"vsMajorVersion": 17,
"insertionTitlePrefix": "[d17.13]"
},
"release/dev17.14": {
Expand All @@ -174,7 +168,6 @@
"NonShipping"
],
"vsBranch": "main",
"vsMajorVersion": 17,
"insertionTitlePrefix": "[d17.14 P3]",
"insertionCreateDraftPR": false
},
Expand All @@ -184,7 +177,6 @@
"NonShipping"
],
"vsBranch": "feature/d18initial",
"vsMajorVersion": 17,
"insertionCreateDraftPR": false,
"insertionTitlePrefix": "[d17.15 P1]"
}
Expand Down