From ad0f63cd4e46588dd6de1207cc2c7bc4ffdb4f60 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Wed, 6 Nov 2024 14:36:31 -0500 Subject: [PATCH 1/4] Update breaking change docs Offline, we had a discussion that the title and H1 were verbose and could be misunderstood. I've updated the most recent 4 documents to match that discussion. Notes for reviewers: All edits in each file should be the same (modulo typos and version numbers). Let's agree on the language on one of them, then make sure they all match. --- .../compilers/CSharp/Compiler Breaking Changes - DotNet 10.md | 4 +++- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md | 2 ++ docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md | 4 +++- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md | 3 ++- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md index 9debb96483dcd..813a2d9616391 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md @@ -1,4 +1,6 @@ -# This document lists known breaking changes in Roslyn after .NET 9 all the way to .NET 10. +# Roslyn breaking changes from .NET 9.0.100 through .NET 10.0.100 + +This document lists known breaking changes in Roslyn after .NET 9 general release (.NET SDK version 9.0.100) through .NET 10 general release (.NET SDK version 10.0).100). ## `Span` and `ReadOnlySpan` overloads are applicable in more scenarios in C# 14 and newer diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md index 16ff18c9ad43f..f2f109de917e0 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md @@ -1,5 +1,7 @@ # This document lists known breaking changes in Roslyn after .NET 6 all the way to .NET 7. +This document lists known breaking changes in Roslyn after .NET 6 all the way to .NET 7. + ## All locals of restricted types are disallowed in async methods ***Introduced in Visual Studio 2022 version 17.6p1*** diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md index 351e636ac80db..ac76dcede1ff5 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md @@ -1,4 +1,6 @@ -# This document lists known breaking changes in Roslyn after .NET 7 all the way to .NET 8. +# Breaking changes in Roslyn from .NET 7.0.100 through .NET 8.0.100 + +This document lists known breaking changes in Roslyn after .NET 7 general release (.NET SDK version 7.0.100) through .NET 8 general release (.NET SDK version 8.0.100). ## Ref modifiers of dynamic arguments should be compatible with ref modifiers of corresponding parameters diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md index b1890cfa20293..459cad1ddb3f9 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md @@ -1,5 +1,6 @@ -# This document lists known breaking changes in Roslyn after .NET 8 all the way to .NET 9. +# Breaking changes in Roslyn from .NET 8.0.100 through .NET 9.0.100 +This document lists known breaking changes in Roslyn after .NET 8 general release (.NET SDK version 8.0.100) through .NET 9 general release (.NET SDK version 9.0.100). ## InlineArray attribute on a record struct type is no longer allowed. From 7c0ddd71170808062ab1e14967216ae38b1f90e7 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Wed, 6 Nov 2024 14:38:09 -0500 Subject: [PATCH 2/4] typo --- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md index 813a2d9616391..c7d9d7e46c415 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md @@ -1,6 +1,6 @@ # Roslyn breaking changes from .NET 9.0.100 through .NET 10.0.100 -This document lists known breaking changes in Roslyn after .NET 9 general release (.NET SDK version 9.0.100) through .NET 10 general release (.NET SDK version 10.0).100). +This document lists known breaking changes in Roslyn after .NET 9 general release (.NET SDK version 9.0.100) through .NET 10 general release (.NET SDK version 10.0.100). ## `Span` and `ReadOnlySpan` overloads are applicable in more scenarios in C# 14 and newer From cd258ed9acbefa979678dd4762430787fc895312 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Wed, 6 Nov 2024 14:52:32 -0500 Subject: [PATCH 3/4] respond to feedback --- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md | 2 +- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md | 2 +- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md index c7d9d7e46c415..89b9a88b9e40d 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md @@ -1,4 +1,4 @@ -# Roslyn breaking changes from .NET 9.0.100 through .NET 10.0.100 +# Roslyn breaking changes after .NET 9.0.100 through .NET 10.0.100 This document lists known breaking changes in Roslyn after .NET 9 general release (.NET SDK version 9.0.100) through .NET 10 general release (.NET SDK version 10.0.100). diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md index ac76dcede1ff5..470853cd3c8f8 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 8.md @@ -1,4 +1,4 @@ -# Breaking changes in Roslyn from .NET 7.0.100 through .NET 8.0.100 +# Breaking changes in Roslyn after .NET 7.0.100 through .NET 8.0.100 This document lists known breaking changes in Roslyn after .NET 7 general release (.NET SDK version 7.0.100) through .NET 8 general release (.NET SDK version 8.0.100). diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md index 459cad1ddb3f9..ce0ac3ee11fe5 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 9.md @@ -1,4 +1,4 @@ -# Breaking changes in Roslyn from .NET 8.0.100 through .NET 9.0.100 +# Breaking changes in Roslyn after .NET 8.0.100 through .NET 9.0.100 This document lists known breaking changes in Roslyn after .NET 8 general release (.NET SDK version 8.0.100) through .NET 9 general release (.NET SDK version 9.0.100). From bfea3c1df7ebf495cf6298151a6f57724c1e8d11 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Wed, 6 Nov 2024 16:38:17 -0500 Subject: [PATCH 4/4] respond to feedback. --- .../compilers/CSharp/Compiler Breaking Changes - DotNet 10.md | 2 +- docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md index 89b9a88b9e40d..b1f6e72765761 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md @@ -1,4 +1,4 @@ -# Roslyn breaking changes after .NET 9.0.100 through .NET 10.0.100 +# Breaking changes in Roslyn after .NET 9.0.100 through .NET 10.0.100 This document lists known breaking changes in Roslyn after .NET 9 general release (.NET SDK version 9.0.100) through .NET 10 general release (.NET SDK version 10.0.100). diff --git a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md index f2f109de917e0..6c6b64d41eb5d 100644 --- a/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md +++ b/docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md @@ -1,6 +1,6 @@ -# This document lists known breaking changes in Roslyn after .NET 6 all the way to .NET 7. +# Breaking changes in Roslyn after .NET 6.0.100 through .NET 7.0.100 -This document lists known breaking changes in Roslyn after .NET 6 all the way to .NET 7. +This document lists known breaking changes in Roslyn after .NET 6 general release (.NET SDK version 6.0.100) through .NET 7 general release (.NET SDK version 7.0.100). ## All locals of restricted types are disallowed in async methods