Reduce allocations in AnalyzerFileReference.GetAnalyzerTypeNameMap #74411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method showed up when investigating a recent regression in allocations due to a change in lightbulb behaviors. Although this method hasn't changed recently, it is one of the easiest ways to claw back some memory during this scenario. Locally, opening the vs-platform solution with this change reduces allocations under GetAnalyzerTypeNameMap from about 1.9% (63 MB) to about 0.1% (5 MB)
ghost
added
Area-Analyzers
untriaged
333fred
reviewed
Jul 17, 2024
| group typeName by supportedLanguage; | ||
|
|
||
| return typeNameMap.ToImmutableSortedDictionary(g => g.Key, g => g.ToImmutableHashSet(), StringComparer.OrdinalIgnoreCase); | ||
| Dictionary<string, ImmutableHashSet<string>.Builder> typeNameMap = new Dictionary<string, ImmutableHashSet<string>.Builder>(StringComparer.OrdinalIgnoreCase); |
Member
There was a problem hiding this comment.
Should we use ImmutableSegmentedHashSet instead?
Contributor
Author
There was a problem hiding this comment.
I didn't see these hitting the LOH in the profile that I looked at, so I'd prefer to keep as-is, without that evidence to back up such a change.
Contributor
Author
|
@dotnet/roslyn-compiler -- ptal |
chsienki
approved these changes
Jul 18, 2024
333fred
approved these changes
Jul 18, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method showed up when investigating a recent regression in allocations due to a change in lightbulb behaviors. Although this method hasn't changed recently, it is one of the easiest ways to claw back some memory during this scenario.
Locally, opening the vs-platform solution with this change reduces allocations under GetAnalyzerTypeNameMap from about 1.9% (63 MB) to about 0.1% (5 MB)
*** previous allocations during vs-platform solution open ***
*** allocations with these changes during vs-platform solution open ***
