Skip to content

SpillSequenceSpiller – preserve ref BoundConditionalOperator in presence of spilling in its either branch #74310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2024
Merged

SpillSequenceSpiller – preserve ref BoundConditionalOperator in presence of spilling in its either branch #74310

merged 3 commits into from
Jul 16, 2024

Conversation

@AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Jul 9, 2024

Fixes #74115.

@AlekseyTs AlekseyTs requested a review from a team as a code owner July 9, 2024 15:07
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 9, 2024
@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented Jul 9, 2024

@dotnet/roslyn-compiler Please review

1 similar comment
@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented Jul 12, 2024

@dotnet/roslyn-compiler Please review

333fred
333fred approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but I would suggest adding one of the test cases from the original bug as well.

@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented Jul 15, 2024

@dotnet/roslyn-compiler For the second review

jcouv
jcouv reviewed Jul 15, 2024
View reviewed changes
src/Compilers/CSharp/Portable/Lowering/SpillSequenceSpiller.cs
consequenceBuilder.Free();
alternativeBuilder.Free();

// 3. Use updated conditional operator as the result. Note, we are using the captured temp as its condition,
Copy link
Member

@jcouv jcouv Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use updated conditional operator as the result

nit: consider calling out that we want to use the original node to maintain proper refness

@jcouv jcouv self-assigned this Jul 15, 2024
jcouv
jcouv approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@AlekseyTs AlekseyTs merged commit 432b124 into dotnet:main Jul 16, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 16, 2024
This was referenced Jul 19, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Feature - Ref Locals and Returns Ref Locals and Returns untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.12 P1

Development

Successfully merging this pull request may close these issues.

Bug: Conditional Operator stores ref result in a non-ref-temporary (Only when SpillSequenceSpiller is used - e.g. for async/await)

4 participants

@AlekseyTs @333fred @jcouv @RikkiGibson