-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Re-add EA.RazorCompiler IVT #72057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add EA.RazorCompiler IVT #72057
Conversation
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.ExpressionCompiler.UnitTests" /> | ||
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator.ExpressionCompiler.UnitTests" /> | ||
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExpressionEvaluator.ExpressionCompiler.Utilities" /> | ||
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add a comment why this is here.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I merged my PR with the project load tests. Will need to merge in main and remove the ignored diagnostics. Lines
can become await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp); |
| }; | ||
|
|
||
| await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp, ignoredDiagnostics); | ||
| await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoeRobich would it be easy to create similar test that's frozen to net8 to ensure we keep supporting this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a tracking issue (#72071) to expand the test coverage to cover more SDKs. Right now we are just validating it works with our pinned SDK, which is a start. =)
Fixes #72015.