Skip to content

Conversation

@jjonescz
Copy link
Member

Fixes #72015.

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 12, 2024
@jjonescz jjonescz marked this pull request as ready for review February 12, 2024 18:47
@jjonescz jjonescz requested a review from a team as a code owner February 12, 2024 18:47
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.ExpressionCompiler.UnitTests" />
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator.ExpressionCompiler.UnitTests" />
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExpressionEvaluator.ExpressionCompiler.Utilities" />
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add a comment why this is here.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoeRobich
Copy link
Member

I merged my PR with the project load tests. Will need to merge in main and remove the ignored diagnostics.

Lines

var ignoredDiagnostics = templateName switch
{
"blazor" or "blazorwasm" or "blazorwasm-empty" =>
[
// The type or namespace name {'csharp_blazor_project'|'App'} could not be found
// (are you missing a using directive or an assembly reference?)
// Bug: https://github.com/dotnet/roslyn/issues/72015
"CS0246",
],
_ => Array.Empty<string>(),
};
await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp, ignoredDiagnostics);

can become

await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp);

};

await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp, ignoredDiagnostics);
await AssertTemplateProjectLoadsCleanlyAsync(templateName, LanguageNames.CSharp);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich would it be easy to create similar test that's frozen to net8 to ensure we keep supporting this scenario?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a tracking issue (#72071) to expand the test coverage to cover more SDKs. Right now we are just validating it works with our pinned SDK, which is a start. =)

@jjonescz jjonescz requested a review from jaredpar February 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSBuildWorkspace does not cleanly load blazorwasm project

5 participants