Skip to content

Only make members required when RequiredMemberAttribute is present #68577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Only make members required when RequiredMemberAttribute is present #68577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Analyzers/CSharp/CodeFixes/MakeMemberRequired/CSharpMakeMemberRequiredCodeFixProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)

var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false);

if (semanticModel.Compilation.GetBestTypeByMetadataName("System.Runtime.CompilerServices.RequiredMemberAttribute") is null)
{
// The attribute necessary to support required members is not present
return;
}

var fieldOrPropertySymbol = semanticModel.GetDeclaredSymbol(node, cancellationToken);
if (fieldOrPropertySymbol is IPropertySymbol propertySymbol)
{
Expand Down
23 changes: 23 additions & 0 deletions src/Analyzers/CSharp/Tests/MakeMemberRequired/MakeMemberRequiredTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using Microsoft.CodeAnalysis.Editor.UnitTests.CodeActions;
using Microsoft.CodeAnalysis.Test.Utilities;
using Microsoft.CodeAnalysis.Testing;
using Roslyn.Test.Utilities;
using Xunit;

namespace Microsoft.CodeAnalysis.CSharp.Analyzers.UnitTests.MakeMemberRequired
Expand Down Expand Up @@ -119,6 +120,28 @@ public static IEnumerable<object[]> AccessorAccessibilityModifierCombinationsWhe
yield return new[] { "internal", "private protected" };
}

[Fact]
[WorkItem("https://github.com/dotnet/roslyn/issues/68478")]
Comment on lines +123 to +124
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Fact]
[WorkItem("https://github.com/dotnet/roslyn/issues/68478")]
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/68478")]

Copy link
Contributor Author

@sharwell sharwell Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➡️ Keeping this one as-is

public async Task SimpleSetPropertyMissingRequiredAttribute()
{
var code =
"""
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my preference would also be consistency. but it's not a deal breaker.

#nullable enable
class MyClass
{
public string {|CS8618:MyProperty|} { get; set; }
}
""";

await new VerifyCS.Test
{
TestCode = code,
FixedCode = code,
LanguageVersion = LanguageVersion.CSharp11,
ReferenceAssemblies = ReferenceAssemblies.Net.Net60,
}.RunAsync();
}

[Fact]
public async Task SimpleSetProperty()
{
Expand Down