Skip to content

Prevent Uri/char[] allocs in RoslynErrorTag.Equals #68525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

Prevent Uri/char[] allocs in RoslynErrorTag.Equals #68525

merged 1 commit into from
Jun 9, 2023

Conversation

@sandyarmstrong
Copy link
Member

@sandyarmstrong sandyarmstrong commented Jun 9, 2023 •
edited by Pilchie
Loading

For the equality check, comparing the underlying HelpLink should be sufficient.

Fixes AB#1824219

@sandyarmstrong
Prevent Uri/char[] allocs in RoslynErrorTag.Equals
c575b34 
For the equality check, comparing the underlying HelpLink
should be sufficient.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1824219
@sandyarmstrong sandyarmstrong requested a review from a team as a code owner June 9, 2023 21:34
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 9, 2023
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 9, 2023 22:06
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Jun 9, 2023

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 0b9b963 into main Jun 9, 2023
@ghost ghost added this to the Next milestone Jun 9, 2023
@sandyarmstrong sandyarmstrong deleted the dev/sandy/roslynerrortag-eq branch June 9, 2023 22:53
@davkean
Copy link
Member

davkean commented Jun 13, 2023

Thanks @sandyarmstrong!

@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.7 P3

Development

Successfully merging this pull request may close these issues.

5 participants

@sandyarmstrong @CyrusNajmabadi @davkean @RikkiGibson