Skip to content

Conversation

@jhinder
Copy link
Contributor

@jhinder jhinder commented Apr 28, 2023

Some of the keyword help texts were string literals, some were generated with the Keyword helper method. Now they are unified to consistently use the helper method.

@jhinder jhinder requested a review from a team as a code owner April 28, 2023 10:27
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 28, 2023
@jhinder
Copy link
Contributor Author

jhinder commented Apr 28, 2023

@CyrusNajmabadi Could you please merge this PR? All checks are green.

@genlu genlu merged commit e3f89a4 into dotnet:main Apr 28, 2023
@ghost ghost added this to the Next milestone Apr 28, 2023
@genlu
Copy link
Member

genlu commented Apr 28, 2023

Thanks! @jhinder

@jhinder jhinder deleted the helpservice-keyword-refactor branch April 29, 2023 16:01
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants