Avoid applying partial changes when a code fix contains a mix of supported and unsupported actions #67262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted and unsupported actions Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1762694
ghost
added
the
sharwell
force-pushed
the
complete-handler
branch
from
dce3852 to
9449fc7
Compare
dibarbet
approved these changes
Mar 10, 2023
Member
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Looks great! I'd just suggest adding a couple sanity tests here to ensure that the add/deletes come through properly - https://sourceroslyn.io/#Microsoft.CodeAnalysis.LanguageServer.Protocol.UnitTests/CodeActions/CodeActionResolveTests.cs,26c5a52ba3d85f10
fine with that happening in a followup or here.
arunchndr
approved these changes
Mar 10, 2023
Contributor
|
@sharwell is this just pending test additions at this point? |
Contributor
Author
|
@arkalyanms yes that's correct |
Member
|
@sharwell I see this PR when checking https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1767589/ |
Cosifne
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1762694