Improve parser error recovery around misplaced semicolon #65089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
CyrusNajmabadi
force-pushed
the
parserErrorRecovery
branch
from
c229830 to
625b16a
Compare
CyrusNajmabadi
force-pushed
the
parserErrorRecovery
branch
from
625b16a to
ab825ed
Compare
Member
Author
|
@dotnet/roslyn-compiler could i get eyes on this? |
333fred
reviewed
Nov 1, 2022
| result = null; | ||
| return false; | ||
|
|
||
| bool isStartOfPropertyBody(SyntaxKind kind) |
Member
There was a problem hiding this comment.
Consider extracting this and using below as well.
Member
Author
333fred
reviewed
Nov 3, 2022
333fred
approved these changes
Nov 4, 2022
Member
Author
cston
reviewed
Nov 7, 2022
|
|
||
| switch (this.CurrentToken.Kind) | ||
| // `{` or `=>` definitely start a property. Also allow | ||
| // `; {` and `; =>` as error recovery fo ra misplaced semicolon. |
CyrusNajmabadi
commented
Nov 7, 2022
cston
reviewed
Nov 7, 2022
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } |
Contributor
Member
Author
There was a problem hiding this comment.
we are, yes. and they def discovered interesting stuff for example, that int MyProperty; { is totally legal at the script/top-level as a local/field, followed by a block :)
cston
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52