Don't use exceptions for flow control #61948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this exception used to bubble all the way up to a command handler that would show its message in the UI, but at some point in the past N years that changed, and the exception now just gets reported via telemetry. This is undesirable, as its a totally expected thing for ILSpy to not be able to decompile in some circumstances, and we gracefully fall back to metadata in those cases.
ghost
added
the
dibarbet
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1514770
I suspect this exception used to bubble all the way up to a command handler that would show its message in the UI, but at some point in the past N years that changed, and the exception now just gets reported via telemetry. This is undesirable, as its a totally expected thing for ILSpy to not be able to decompile in some circumstances, and we gracefully fall back to metadata in those cases.