Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up integration tests and make it required in PR validation #64545

Closed
arunchndr opened this issue Oct 6, 2022 · 4 comments
Closed

Fix up integration tests and make it required in PR validation #64545

arunchndr opened this issue Oct 6, 2022 · 4 comments
Assignees
Labels
Area-IDE Bug Integration-Test Test failures in roslyn-integration-CI
Milestone

Comments

@arunchndr
Copy link
Member

Starting with Joey to close out his open PRs to evaluate if we need further work here. @Cosifne can help as needed.

@arunchndr arunchndr added this to the 17.5 P1 milestone Oct 6, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 6, 2022
@arunchndr arunchndr added Bug Integration-Test Test failures in roslyn-integration-CI and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 6, 2022
@Cosifne
Copy link
Member

Cosifne commented Oct 6, 2022

A couple of things on my list :

  1. Navigate test might be flaky (not very flaky) The root reason seems like http://index/?leftProject=Microsoft.VisualStudio.Shell.UI.Internal&leftSymbol=mrcrzs7nl8wa&file=Packages%5CSearch%5CPackage%5CPackageAllInOneSearchButtonPresenter.cs&line=67 This fire and forget task
    (Update: this is fixed using a workaround polling mechanism in this PR Update NavigateTo tests to support AllInOneSearch #64582, it is less flaky now, but ideally we need to talk to platform folks to give us a way to wait on these fire and forget tasks)
  2. Timeout. This looks like caused because
    a. https://sourceroslyn.io/#Microsoft.VisualStudio.LanguageServices.IntegrationTests/VisualBasic/BasicWinForms.cs,17
    Some tests here
    timeout (21)
    A mystery that it is saving resx file???
    (Update: fix in Save the resx file after a button is added into the WinForm #64910)

b. Either this test or this
is waiting forever so it caused a timeout.
timeout (27)
(This problem is solved #64746)

@JoeRobich
Copy link
Member

Will need to investigate why QuickInfo session was being returned as null in Workspace ProjectProperties tests #64672

@JoeRobich
Copy link
Member

I asked @jasonmalinowski to look at #64721, but he may not have time for a few days.

@Cosifne
Copy link
Member

Cosifne commented Nov 4, 2022

Closed the issue because Integration tests has a good pass rate now and it is enabled as required again.

@Cosifne Cosifne closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Development

No branches or pull requests

3 participants