Skip to content

Commit e635cb0

Browse files
authored
Merge pull request #61866 from dotnet/merges/release/dev17.1-to-release/dev17.2
Merge release/dev17.1 to release/dev17.2
2 parents 9521db7 + bd35b1e commit e635cb0

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

eng/Version.Details.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@
1313
</Dependency>
1414
</ProductDependencies>
1515
<ToolsetDependencies>
16-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.22225.6">
16+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.22306.1">
1717
<Uri>https://github.com/dotnet/arcade</Uri>
18-
<Sha>5145e86df0c491e082b589aa31d69eea300adc02</Sha>
18+
<Sha>7f522f2e42fd8c2064afb45eac34a1773ce6a1cc</Sha>
1919
<SourceBuild RepoName="arcade" ManagedOnly="true" />
2020
</Dependency>
2121
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.1.0-5.22128.4">
2222
<Uri>https://github.com/dotnet/roslyn</Uri>
2323
<Sha>5d10d428050c0d6afef30a072c4ae68776621877</Sha>
2424
</Dependency>
25-
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="7.0.0-beta.22225.6">
25+
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="7.0.0-beta.22306.1">
2626
<Uri>https://github.com/dotnet/arcade</Uri>
27-
<Sha>5145e86df0c491e082b589aa31d69eea300adc02</Sha>
27+
<Sha>7f522f2e42fd8c2064afb45eac34a1773ce6a1cc</Sha>
2828
</Dependency>
2929
</ToolsetDependencies>
3030
</Dependencies>

eng/common/init-tools-native.ps1

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ try {
9393
$ToolVersion = ""
9494
}
9595
$ArcadeToolsDirectory = "C:\arcade-tools"
96-
if (Test-Path $ArcadeToolsDirectory -eq $False) {
96+
if (-not (Test-Path $ArcadeToolsDirectory)) {
9797
Write-Error "Arcade tools directory '$ArcadeToolsDirectory' was not found; artifacts were not properly installed."
9898
exit 1
9999
}
@@ -103,13 +103,14 @@ try {
103103
exit 1
104104
}
105105
$BinPathFile = "$($ToolDirectory.FullName)\binpath.txt"
106-
if (Test-Path -Path "$BinPathFile" -eq $False) {
106+
if (-not (Test-Path -Path "$BinPathFile")) {
107107
Write-Error "Unable to find binpath.txt in '$($ToolDirectory.FullName)' ($ToolName $ToolVersion); artifact is either installed incorrectly or is not a bootstrappable tool."
108108
exit 1
109109
}
110110
$BinPath = Get-Content "$BinPathFile"
111-
Write-Host "Adding $ToolName to the path ($(Convert-Path -Path $BinPath))..."
112-
Write-Host "##vso[task.prependpath]$(Convert-Path -Path $BinPath)"
111+
$ToolPath = Convert-Path -Path $BinPath
112+
Write-Host "Adding $ToolName to the path ($ToolPath)..."
113+
Write-Host "##vso[task.prependpath]$ToolPath"
113114
}
114115
}
115116
exit 0
@@ -188,7 +189,7 @@ try {
188189
Write-Host "##vso[task.prependpath]$(Convert-Path -Path $InstallBin)"
189190
return $InstallBin
190191
}
191-
else {
192+
elseif (-not ($PathPromotion)) {
192193
Write-PipelineTelemetryError -Category 'NativeToolsBootstrap' -Message 'Native tools install directory does not exist, installation failed'
193194
exit 1
194195
}

eng/common/internal/Tools.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
<ItemGroup>
99
<!-- Clear references, the SDK may add some depending on UsuingToolXxx settings, but we only want to restore the following -->
1010
<PackageReference Remove="@(PackageReference)"/>
11+
<PackageReference Include="Microsoft.ManifestTool.CrossPlatform" Version="$(MicrosoftManifestToolCrossPlatformVersion)" />
12+
<PackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Core" Version="$(MicrosoftVisualStudioEngMicroBuildCoreVersion)" />
13+
<PackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild" Version="$(MicrosoftVisualStudioEngMicroBuildPluginsSwixBuildVersion)" />
1114
<PackageReference Include="Microsoft.DotNet.IBCMerge" Version="$(MicrosoftDotNetIBCMergeVersion)" Condition="'$(UsingToolIbcOptimization)' == 'true'" />
1215
<PackageReference Include="Drop.App" Version="$(DropAppVersion)" ExcludeAssets="all" Condition="'$(UsingToolVisualStudioIbcTraining)' == 'true'"/>
1316
</ItemGroup>

eng/common/tools.ps1

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,6 +635,10 @@ function InitializeNativeTools() {
635635
InstallDirectory = "$ToolsDir"
636636
}
637637
}
638+
if (Test-Path variable:NativeToolsOnMachine) {
639+
Write-Host "Variable NativeToolsOnMachine detected, enabling native tool path promotion..."
640+
$nativeArgs += @{ PathPromotion = $true }
641+
}
638642
& "$PSScriptRoot/init-tools-native.ps1" @nativeArgs
639643
}
640644
}

global.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"xcopy-msbuild": "16.10.0-preview2"
1313
},
1414
"msbuild-sdks": {
15-
"Microsoft.DotNet.Arcade.Sdk": "7.0.0-beta.22225.6",
16-
"Microsoft.DotNet.Helix.Sdk": "7.0.0-beta.22225.6"
15+
"Microsoft.DotNet.Arcade.Sdk": "7.0.0-beta.22306.1",
16+
"Microsoft.DotNet.Helix.Sdk": "7.0.0-beta.22306.1"
1717
}
1818
}

0 commit comments

Comments
 (0)