Comment out CS1998 warning definition and delete associated resources

Co-authored-by: 333fred <[email protected]>

Author: Copilot

src/Analyzers/CSharp/CodeFixes/MakeMethodSynchronous/CSharpMakeMethodSynchronousCodeFixProvider.cs

@@ -22,9 +22,11 @@ namespace Microsoft.CodeAnalysis.CSharp.MakeMethodSynchronous;
 [method: SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")]
 internal sealed class CSharpMakeMethodSynchronousCodeFixProvider() : AbstractMakeMethodSynchronousCodeFixProvider
 {
-    private const string CS1998 = nameof(CS1998); // This async method lacks 'await' operators and will run synchronously.
+    // CS1998 warning has been removed entirely as per https://github.com/dotnet/roslyn/issues/77001
+    // private const string CS1998 = nameof(CS1998); // This async method lacks 'await' operators and will run synchronously.
 
-    public override ImmutableArray<string> FixableDiagnosticIds { get; } = [CS1998];
+    // Code fix provider disabled since CS1998 warning no longer exists
+    public override ImmutableArray<string> FixableDiagnosticIds { get; } = [];
 
     protected override bool IsAsyncSupportingFunctionSyntax(SyntaxNode node)
         => node.IsAsyncSupportingFunctionSyntax();

src/Analyzers/CSharp/CodeFixes/RemoveAsyncModifier/CSharpRemoveAsyncModifierCodeFixProvider.cs

@@ -22,9 +22,11 @@ namespace Microsoft.CodeAnalysis.CSharp.RemoveAsyncModifier;
 [method: SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")]
 internal sealed partial class CSharpRemoveAsyncModifierCodeFixProvider() : AbstractRemoveAsyncModifierCodeFixProvider<ReturnStatementSyntax, ExpressionSyntax>
 {
-    private const string CS1998 = nameof(CS1998); // This async method lacks 'await' operators and will run synchronously.
+    // CS1998 warning has been removed entirely as per https://github.com/dotnet/roslyn/issues/77001
+    // private const string CS1998 = nameof(CS1998); // This async method lacks 'await' operators and will run synchronously.
 
-    public override ImmutableArray<string> FixableDiagnosticIds { get; } = [CS1998];
+    // Code fix provider disabled since CS1998 warning no longer exists
+    public override ImmutableArray<string> FixableDiagnosticIds { get; } = [];
 
     protected override bool IsAsyncSupportingFunctionSyntax(SyntaxNode node)
         => node.IsAsyncSupportingFunctionSyntax();

src/Analyzers/CSharp/Tests/MakeMethodSynchronous/MakeMethodSynchronousTests.cs

@@ -17,6 +17,7 @@ namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.MakeMethodSynchronous;
     CSharpMakeMethodSynchronousCodeFixProvider>;
 
 [Trait(Traits.Feature, Traits.Features.CodeActionsMakeMethodSynchronous)]
+[Trait(Traits.Feature, Traits.Features.Skip)]  // CS1998 warning removed entirely - https://github.com/dotnet/roslyn/issues/77001
 public sealed class MakeMethodSynchronousTests
 {
     [Fact]

src/Analyzers/CSharp/Tests/RemoveAsyncModifier/RemoveAsyncModifierTests.cs

@@ -18,6 +18,7 @@ namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.RemoveAsyncModifier;
     CSharpRemoveAsyncModifierCodeFixProvider>;
 
 [Trait(Traits.Feature, Traits.Features.CodeActionsRemoveAsyncModifier)]
+[Trait(Traits.Feature, Traits.Features.Skip)]  // CS1998 warning removed entirely - https://github.com/dotnet/roslyn/issues/77001
 public sealed class RemoveAsyncModifierTests
 {
     [Fact]

src/Compilers/CSharp/Portable/CSharpResources.resx

@@ -3833,12 +3833,14 @@ Give the compiler some way to differentiate the methods. For example, you can gi
   <data name="ERR_BadAwaitInQuery" xml:space="preserve">
     <value>The 'await' operator may only be used in a query expression within the first collection expression of the initial 'from' clause or within the collection expression of a 'join' clause</value>
   </data>
+  <!-- WRN_AsyncLacksAwaits resources removed as per https://github.com/dotnet/roslyn/issues/77001
   <data name="WRN_AsyncLacksAwaits" xml:space="preserve">
     <value>This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.</value>
   </data>
   <data name="WRN_AsyncLacksAwaits_Title" xml:space="preserve">
     <value>Async method lacks 'await' operators and will run synchronously</value>
   </data>
+  -->
   <data name="WRN_UnobservedAwaitableExpression" xml:space="preserve">
     <value>Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.</value>
   </data>

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

@@ -1024,7 +1024,7 @@ internal enum ErrorCode
         ERR_BadAwaitInQuery = 1995,
         ERR_BadAwaitInLock = 1996,
         ERR_TaskRetNoObjectRequired = 1997,
-        WRN_AsyncLacksAwaits = 1998,
+        // WRN_AsyncLacksAwaits = 1998, // Removed as per https://github.com/dotnet/roslyn/issues/77001
         ERR_FileNotFound = 2001,
         WRN_FileAlreadyIncluded = 2002,
         //ERR_DuplicateResponseFile = 2003,

src/Compilers/CSharp/Portable/Errors/ErrorFacts.cs

@@ -411,7 +411,7 @@ internal static int GetWarningLevel(ErrorCode code)
                 case ErrorCode.WRN_CallerLineNumberPreferredOverCallerFilePath:
                 case ErrorCode.WRN_DelaySignButNoKey:
                 case ErrorCode.WRN_UnimplementedCommandLineSwitch:
-                case ErrorCode.WRN_AsyncLacksAwaits:
+                // case ErrorCode.WRN_AsyncLacksAwaits: // Removed as per https://github.com/dotnet/roslyn/issues/77001
                 case ErrorCode.WRN_BadUILang:
                 case ErrorCode.WRN_RefCultureMismatch:
                 case ErrorCode.WRN_ConflictingMachineAssembly:
@@ -1485,7 +1485,7 @@ or ErrorCode.ERR_BadAsyncLacksBody
                 or ErrorCode.ERR_BadAwaitInQuery
                 or ErrorCode.ERR_BadAwaitInLock
                 or ErrorCode.ERR_TaskRetNoObjectRequired
-                or ErrorCode.WRN_AsyncLacksAwaits
+                // or ErrorCode.WRN_AsyncLacksAwaits // Removed as per https://github.com/dotnet/roslyn/issues/77001
                 or ErrorCode.ERR_FileNotFound
                 or ErrorCode.WRN_FileAlreadyIncluded
                 or ErrorCode.ERR_NoFileSpec

src/Compilers/CSharp/Portable/Generated/ErrorFacts.Generated.cs

@@ -52,17 +52,14 @@ select x * x
 . {{
 .   return new int[] {{ 1, 2, 3, 4, 5 }};
 . }}
-«Yellow»
-(1,19): warning CS1998: {CSharpResources.WRN_AsyncLacksAwaits}
-«Gray»
 > from x in await GetStuffAsync()
 . where x > 2
 . select x * x
 Enumerable.{iteratorType}<int, int> {{ 9, 16, 25 }}
 > ", runner.Console.Out.ToString());
 
             AssertEx.AssertEqualToleratingWhitespaceDifferences(
-                $@"(1,19): warning CS1998: {CSharpResources.WRN_AsyncLacksAwaits}",
+                "",
                 runner.Console.Error.ToString());
         }